-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add field and check donation for phone verified #4594
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are two things that still need to be implemented:
- It would be good to return the
has_donated
flag in GetAccountInfo (account.proto/account.py) - We need to somehow populate the
has_donated
flag when we set it up so that those who have already donated get it ticked off. I can help make this happen in the migration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Database migrations (update the
has_donated
flag based on existing data in the database) -- I can help with this: it's going to be complicated
This needs a database query to check who has already donated based on existing tables, so we set has_donated=True
for those users.
- Add a env var flag or constant in
constants.py
as to whether to enforce this or not. So we can update the frontend first.
@Krishnag09 : could you please rebase onto Are you OK if I push a commit to fix up the migrations onto this branch? Other than that and minor formatting stuff (I can fix that up too), I think this is looking good to go! |
541e727
to
be6d591
Compare
be6d591
to
178f3b2
Compare
178f3b2
to
1f22e6c
Compare
1f22e6c
to
a18064d
Compare
…nd/feature/strong-verification
do you still want me to do these? |
It's all done now in the commit I pushed. I think it just needs an update to the migration (to say down revision is But let's wait a little bit before merging so I can do the frontend part first! |
The PR adds a new profile field to track donation, to act as a paywall for phone verification
closes the issue - #4349
--->
Backend checklist
ruff check --select I --fix . && ruff check . && ruff format .
inapp/backend
develop
if necessary for linear migration historyWeb frontend checklist
make format
make lint