Fix black test failure in CI #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeipollack
reviewed
Feb 23, 2024
jeipollack
reviewed
Feb 23, 2024
jeipollack
reviewed
Mar 1, 2024
jeipollack
reviewed
Mar 4, 2024
pyproject.toml
Outdated
| @@ -53,8 +53,8 @@ release = [ | |||
|
|
|||
| test = [ | |||
| "pytest", | |||
| "pytest-black", | |||
| "pytest-cases", | |||
| #"pytest-black", | |||
There was a problem hiding this comment.
You commented them out, but we don't want commented lines in the pyproject.toml file. Just remove them.
There was a problem hiding this comment.
ok I will. I commented them to remember to add them once the plugins are compatible with PyTest.
There was a problem hiding this comment.
We should use issues as reminder.
There was a problem hiding this comment.
changes are done.
nadamoukaddem
force-pushed
the
fix/black-test-failure
branch
from
586df3a to
d3b3619
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR should solve #119.
To address the issue, I temporarily set the pytest version to 7.4.4 and reformatted the code. Additionally, I upgraded the Python version in CI to 3.10.12.