Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc files #117

Merged
merged 5 commits into from
Mar 1, 2024
Merged

Add doc files #117

merged 5 commits into from
Mar 1, 2024

Conversation

nadamoukaddem
Copy link
Contributor

solves #114. Additionally, I downgraded the pytest version in the pyproject.toml file so it can pass the tests with pytest.

@nadamoukaddem nadamoukaddem added the documentation Improvements or additions to documentation label Feb 13, 2024
@nadamoukaddem nadamoukaddem self-assigned this Feb 13, 2024
@nadamoukaddem nadamoukaddem changed the title Add doc files and downgrade pytest Add doc files Feb 22, 2024
jeipollack
jeipollack reviewed Mar 1, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
jeipollack
jeipollack reviewed Mar 1, 2024
View reviewed changes
branching_model.png Outdated Show resolved Hide resolved
jeipollack
jeipollack reviewed Mar 1, 2024
View reviewed changes
Copy link
Contributor

@jeipollack jeipollack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though the CI tests fail, the scope of this PR is just documentation.
Let me know when you do the small changes so I can do the merge. Thanks.

@nadamoukaddem
Copy link
Contributor Author

I made the changes.

@jeipollack jeipollack merged commit 384f6d9 into develop Mar 1, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeipollack jeipollack jeipollack left review comments

Assignees

@nadamoukaddem nadamoukaddem

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
Modelling Performance Enhancement
Development

Successfully merging this pull request may close these issues.
2 participants
@nadamoukaddem @jeipollack