Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typo check to CI #2032

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Add typo check to CI #2032

merged 2 commits into from
Nov 12, 2024

Conversation

chipshort
Copy link
Collaborator

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.87%. Comparing base (9c2f332) to head (d824a11).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2032      +/-   ##
==========================================
+ Coverage   42.85%   42.87%   +0.01%     
==========================================
  Files          85       85              
  Lines       11587    11587              
==========================================
+ Hits         4966     4968       +2     
+ Misses       6180     6179       -1     
+ Partials      441      440       -1     
Files with missing lines Coverage Δ
tests/ibctesting/endpoint.go 0.00% <ø> (ø)
x/wasm/keeper/querier.go 77.27% <100.00%> (ø)
x/wasm/migrations/v1/store.go 80.00% <ø> (ø)
x/wasm/migrations/v2/legacy_types.go 21.81% <ø> (ø)
x/wasm/migrations/v3/legacy_types.go 33.87% <ø> (ø)
x/wasm/types/gas_register.go 97.40% <ø> (ø)
x/wasm/types/keys.go 52.30% <ø> (ø)
x/wasm/types/wasmer_engine.go 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

iNdEx = "iNdEx"

[files]
extend-exclude = ["**/go.mod", "**/go.sum", "**/*.pb.go"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some excludes here to avoid checking package hashes and generated files. There was already one false-positive in go.sum.

extend-ignore-re = ["(?Rm)^.*(#|//)\\s*spellchecker:disable-line$"]

[default.extend-identifiers]
iNdEx = "iNdEx"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also added this, since it is used as a variable name in legacy_types.go

Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have this in wasmd! LGTM 👍

@chipshort chipshort merged commit 4806a6e into main Nov 12, 2024
20 checks passed
@chipshort chipshort deleted the co/typos branch November 12, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants