Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor test case #2022

Merged
merged 1 commit into from
Nov 5, 2024
Merged

chore: Refactor test case #2022

merged 1 commit into from
Nov 5, 2024

Conversation

kulikthebird
Copy link
Contributor

@kulikthebird kulikthebird commented Nov 5, 2024

This PR refactors one of the migration related test case. Reduces duplication of the code

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.82%. Comparing base (60ed81c) to head (c0a4a60).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2022      +/-   ##
==========================================
+ Coverage   48.80%   48.82%   +0.01%     
==========================================
  Files          65       65              
  Lines       10082    10082              
==========================================
+ Hits         4921     4923       +2     
+ Misses       4726     4725       -1     
+ Partials      435      434       -1     

see 1 file with indirect coverage changes

Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chipshort chipshort merged commit 9a485bf into main Nov 5, 2024
17 checks passed
@chipshort chipshort deleted the tkulik/refactor branch November 5, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants