Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBC Fees #1946

Merged
merged 4 commits into from
Nov 11, 2024
Merged

IBC Fees #1946

merged 4 commits into from
Nov 11, 2024

Conversation

chipshort
Copy link
Collaborator

@chipshort chipshort commented Aug 5, 2024

corresponding wasmvm PR: CosmWasm/wasmvm#545

@chipshort chipshort changed the title Co/ibc fees IBC Fees Aug 5, 2024
@chipshort chipshort marked this pull request as draft August 5, 2024 12:19
@chipshort chipshort added this to the v0.54.0 milestone Sep 5, 2024
@chipshort chipshort marked this pull request as ready for review November 7, 2024 14:55
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 71.79487% with 11 lines in your changes missing coverage. Please review.

Project coverage is 48.89%. Comparing base (6fa6afc) to head (248baf8).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
x/wasm/keeper/handler_plugin_encoders.go 73.68% 5 Missing and 5 partials ⚠️
x/wasm/keeper/capabilities.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1946      +/-   ##
==========================================
+ Coverage   48.82%   48.89%   +0.06%     
==========================================
  Files          65       65              
  Lines       10082    10121      +39     
==========================================
+ Hits         4923     4949      +26     
- Misses       4725     4732       +7     
- Partials      434      440       +6     
Files with missing lines Coverage Δ
x/wasm/keeper/capabilities.go 0.00% <0.00%> (ø)
x/wasm/keeper/handler_plugin_encoders.go 79.41% <73.68%> (-0.82%) ⬇️

... and 1 file with indirect coverage changes

@chipshort chipshort requested a review from pinosu November 8, 2024 05:32
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good tests! LGTM 👍

@chipshort chipshort merged commit 9b2b246 into main Nov 11, 2024
17 checks passed
@chipshort chipshort deleted the co/ibc-fees branch November 11, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants