fix: Use same bound type for start and end of iteration #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uint
approved these changes
Sep 23, 2024
|
👍 Marked as ready. Anything else we need to add here (CHANGELOG or breakage consideration)? If not, feel free to merge |
|
Actually, any chance you could prepend |
|
Does it have to be the commit or do PRs also work? I see many projects doing that on PR level. |
No idea, we could try and see if it works. |
webmaster128
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change I ran into the problem of obscure error messages due to inability to infer the bound type for a
Nonevalue. I hit it in a contract as follows:I could reproduce the problem in the local test cases with
Nonestarts or ends. I don't think that we need to support different start and end bound types in the same call. Users can convert then in the unlikely event that they come in different types. But let me know if this is an important feature which I did not understand.