Improve english & re-vamp whole book #47
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making this guide! While going through trying to understand, having many German friends I recognised instantly some of the odd use of English, and in fact a lot of the difficulties in understanding it came from some issues in the language, in addition to some errors and other issues. I therefore did a wholesale revamp of the book while going through it (which took much longer than expected)
general improvements & corrections:
Main objective was to make this easier to read and understand, to correct the grammatical errors and to make the English sound more natural.
Germanglish -> English ;) (eg "Hopefully, ..." -> "Thankfully, ...", excessive use of commas and long incomprehensible sentences, odd Deutsch-sounding turns of phrase or just incorrect grammar or punctuation, inconsistent tenses, incorrect or awkward use of this/that would/will, "nevermore" etc. etc.)
e.g. (from before edit)
"Now let's take a look at handling results with
2
-4
options. It is actuallyinteresting, that using
2
, even if the transaction is performed by sub-callsucceed, we may now take a look at the data it returned with
Reply
, and onits final state after it finished, and we can still decide, that act as a
whole is a failure, in which case everything would be rolled back - even
currency transfer performed by external contract."
Totally incomprehensible ;)
changed to gender-neutral where unnecessary to specify
unnecessary repetitive language (sometimes) removed (eg "As mentioned before..." )
removed inconsistencies in use of I/we (chose the less egotistic version to go with). This is probably the most "opinionated" change, but I think it makes it less weird to read.
I mostly ignored the over-use (and often incorrect use) of hypenation (-), assuming it is stylistic, except where it was painful. Also left in some anachronisms which nevertheless allow character of the author to pass through
I also noticed that there is quite a bit of repetition in the second part of the book, almost as if two separate documents were pulled together? Anyway, of course I just corrected it as it is (and was useful to have the review on the topics anyway :) )
of course it is possible that some small gremlins crept in, but I did two passes and it is in my opinion a much improved script
I do believe the result is much easier to read and understand, which will mean it is more accessible, so I hope it is helpful, and thanks again for sharing your deep knowledge and skills with us! :)