This repository has been archived by the owner on Nov 1, 2024. It is now read-only.
Добавление баланса в кпк #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FireNameFN
suggested changes
May 22, 2024
Content.Server/PDA/PdaSystem.cs
Outdated
| if (TryComp<BankAccountComponent>(actor_uid, out var bank)) { | ||
| balance = (ulong)bank.Balance; | ||
| } | ||
| } |
There was a problem hiding this comment.
Не по конвенциям стоят {.
Да и не нужны они, когда одна строчка.
Да и ифы можно объединить.
И тебе следует использовать тот тип, что у тебя в bank.Balance, а не ulong
There was a problem hiding this comment.
нельзя, зачем исполнять второе если первое нулл
There was a problem hiding this comment.
if (actor_uid != null && TryComp<BankAccountComponent>(actor_uid, out var bank))
balance = (ulong)bank.Balance;There was a problem hiding this comment.
И лучше bank переименуй а account, ведь он там главное слово
|
И в следующий раз можешь удалить мусор из первого комментария
|
added 2 commits
May 22, 2024 21:12
FireNameFN
suggested changes
May 23, 2024
FireNameFN
approved these changes
May 23, 2024
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Why / Balance
How to test
Media
Breaking changes
Changelog