-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Overhaul training #2314
base: master
Are you sure you want to change the base?
[RFC] Overhaul training #2314
Conversation
44b4875
to
2a416c6
Compare
As Alberth said, we're not likely to get balance testers until the PR is in the game so I've marked as ready. If we're merging let me know first so I can remove all the comments for the wiki. |
Wiki comments removed now ahead of time. You can view them still under 98bb983 as removed lines. |
d652ef7
to
47343c4
Compare
47343c4
to
9784027
Compare
1bc9a02
to
7a38fad
Compare
7a38fad
to
68db169
Compare
So it actually benefits adding more objects to the room (with diminishing benefits)
68db169
to
3067c17
Compare
Great enhancement. |
You can get the branch in 2-3 ways:
GH documents how to get a PR: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Now you can do Then switch to the You can also get the changes of the branch as |
@Alberth289346 thanks for the detailed instructions 👍 I get that functionality with your help 👌 |
Fixes #1458
Fixes #2262
Fixes #2603
Describe what the proposed change does
math.rand modulo
function was not incorporated, as it caused a lot of groundhog day scenarios with docs nearer consultant levelFor award values following this PR: (before PR general skill was 0.0035 regardless of factors)
(Another comparison is Cons. Psychiatrist with trainee psych skill per day: Before PR - 0.0118; After PR: - 0.0105)
Please do test this as I need to know whether the balance is correct. If you need a good level in the main game try Level 9