Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Tests #60

Merged
merged 6 commits into from
Aug 1, 2024
Merged

Refactor Tests #60

merged 6 commits into from
Aug 1, 2024

Conversation

n7studios
Copy link
Contributor

@n7studios n7studios commented Jul 31, 2024 •
edited
Loading

Summary

Refactor the FormCest tests by removing repetitive code.

Adds testCreateFormToConvertKitLegacyFormMapping, to make sure legacy form selection works.

Testing

Existing tests pass.

Checklist

@n7studios n7studios added the enhancement New feature or request label Jul 31, 2024
@n7studios n7studios self-assigned this Jul 31, 2024
@n7studios n7studios requested review from a team, noelherrick and corydhmiller and removed request for a team July 31, 2024 08:52
@n7studios n7studios marked this pull request as ready for review July 31, 2024 08:52
@n7studios n7studios merged commit 2da5754 into add-sequence-subscribe-option Aug 1, 2024
27 checks passed
@n7studios n7studios deleted the refactor-tests branch October 4, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noelherrick noelherrick noelherrick approved these changes

@corydhmiller corydhmiller Awaiting requested review from corydhmiller corydhmiller was automatically assigned from ConvertKit/wordpress

Assignees

@n7studios n7studios

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n7studios @noelherrick