Prefix Form ID in Settings #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the introduction of <optgroup>, whilst the form order is correct, the assertions fail
n7studios
requested review from
a team,
noelherrick and
corydhmiller
and removed request for
a team
n7studios
commented
Jul 30, 2024
| @@ -372,9 +372,6 @@ public function configureConvertKitSettingsOnForm($I, $wpFormID, $formName, $nam | |||
| $I->waitForElementVisible('div[data-connection_id="' . $connectionID . '"] .wpforms-provider-fields'); | |||
|
|
|||
| if ($formName) { | |||
| // Confirm that Forms are in ascending alphabetical order. | |||
| $I->checkSelectFormOptionOrder($I, '[name="providers[convertkit][' . $connectionID . '][list_id]"]'); | |||
There was a problem hiding this comment.
Introducing optgroup to the dropdown selector makes this test fail, as it can't seem to grab the right option value to perform the assertion with. It's the only place used so don't think it's vital to keep checking this.
noelherrick
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Similar to the WooCommerce Plugin, prefixes the settings in Contact Form 7 with
form:, so we know the IDs specified relate to ConvertKit Forms.This allows adding Tags and Sequences to the dropdown options to assign to the subscriber in a later PR.
Testing
testCreateFormToConvertKitFormMapping: Renamed test to reflect this checks subscribing works when defining a ConvertKit Form IDtestCreateFormSubscribeOnly: Test that subscribing works when theSubscribeoption is selected, instead of a ConvertKit FormtestFormSettingsPrefixAddedToSettingsOnUpgrade: Test that settings are migrated to theform:idformat on Plugin update/upgrade.Checklist