Add price_formatted and list_price_formatted fields #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clerk module has built-in "price" and "list_price" fields to sync. They both are float.
When it comes to display these prices to user, for the moment it's possible to use Clerk's formatting methods (see https://docs.clerk.io/docs/template-language), there are two functions: "money" and "money_eu". E.g.:
{{money price 2 "," "."}}
{{money list_price 2 "," "."}}
This way the information how to format a currency is doubled: Magento itself has currency format for prices, now Clerk should know how to format prices. I think the better approach is to have a "single source of truth": so, Magento formats prices and sends it to Clerk, Clerk should not keep any logic how to format data, Clerk should display it as it is.