This repository has been archived by the owner on Jul 29, 2022. It is now read-only.
Merge upstream master #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the promise of the doc is to be able, once run twice with objc/java and go, to import the generated code into a package and build a c-archive for iOS and a c-shared for Android. As of today, this promise is not kept. Imports were not properly made, files were missing. Also, make it generates the output `gomobile bind` does. Change-Id: Ic28087fe1b1661d54f41c446233580856e3a1211 Reviewed-on: https://go-review.googlesource.com/87715 Reviewed-by: Elias Naur <[email protected]>
If a Go struct or interface has the same name as its package class, append an underscore to the generated Java class name. Fixes golang/go#23327. Change-Id: Ib680af35c956801073a0effb510a3ed9bbb8b9d1 Reviewed-on: https://go-review.googlesource.com/87656 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Windows bindings had few invalid bindings. Debug type had a typo, making gldebug non-compilable. Use consistently .c() for types. Fixes golang/go#23451 Change-Id: Ic9e68b1aafcd732dd5e4d8f883324723a35d24c3 Reviewed-on: https://go-review.googlesource.com/87855 Reviewed-by: Elias Naur <[email protected]>
Since the xcrun binary exists in macOS from the beginning, it can not be used to check that Xcode is available. The xcodebuild command does not return an error if Xcode is available. Reference https://go-review.googlesource.com/c/mobile/+/35852 Change-Id: Ibb6324a2d801eab47b3544c50ee1cdbc36b608bc Reviewed-on: https://go-review.googlesource.com/88755 Reviewed-by: Elias Naur <[email protected]>
The test in CL 87656 exposed the problem that an ObjC class C in header C.h can't implement an interface I in I.h if I.h itself includes C.h, resulting in an include cycle. Avoid the problem for now by restricting the set of declared interfaces to the current package and its imports. This is too strict, but simple and avoids any include cycles. Fixes the bind/objc SeqTest on iOS. Change-Id: I2ff964593cb9e56994c42b68cc49eebe2f549217 Reviewed-on: https://go-review.googlesource.com/88818 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Change-Id: I624bbbb5aeda923aa48c37af9447bc4903b0de3f Reviewed-on: https://go-review.googlesource.com/93996 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
…ation When there is no prior gradle cache (i.e .gradle/ directory isn't created yet) in your Android project and a gradle build command is executed (e.g ./gradlew build), the *.so files generated by the gobind android plugin is not packaged into the apk. Successive builds work fine though. This issue doesn't happen when using Android plugin version 2.x, but does using version 3.x. The gomobile bind task, libTask, is only finalizing the java compile task which allows it to run in parallel with javaCompile. That is probably too late, so instead, make libTask a dependency of the compile task to make sure the output of gomobile bind (in particular, the *so libraries) are included in the final build product. Fixes golang/go#23766 Change-Id: I62727bfa0ffd54d8158c3a2aa3d7303867fcbabc Reviewed-on: https://go-review.googlesource.com/94835 Reviewed-by: Elias Naur <[email protected]>
https://plugins.gradle.org/plugin/org.golang.mobile.bind/0.2.11 Built/published with $ docker run --rm -u root -v "$PWD":/home/gradle/project \ -w /home/gradle/project gradle:latest gradle publishPlugins Gradle version 4.5.1 Change-Id: I431101a2b9000147430632ec24e76e8216c66935 Reviewed-on: https://go-review.googlesource.com/95455 Reviewed-by: Elias Naur <[email protected]>
Updates golang/go#23835 Change-Id: If4aea8fde3b6b66980573d94f0d2189396f6a50c Reviewed-on: https://go-review.googlesource.com/93997 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Remove the android support library dependency. The Android build system assumes at least one resource, so add a dummy string. Change-Id: I7223b75709f1aa5907e6d04bc656eea5503bb640 Reviewed-on: https://go-review.googlesource.com/94195 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
…sing Change-Id: I1cf92bb03c420e1eddaa36824cf488c5ed6f5a78 Reviewed-on: https://go-review.googlesource.com/93998 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
A check for the NDK was missing from the pre-install of the standard library for each Android GOARCH. If the NDK wasn't set, the go install invocation would silently use the host GOARCH and GOOS and only fail if no host gcc was found for runtime/cgo. Discovered while setting up gomobile on a clean Windows machine. With the go 1.10 cache go installing the standard library might be pointless, but let's wait a little before removing it. Change-Id: I880eed32aad23fda10ae92bd35be2ce9b03ddb86 Reviewed-on: https://go-review.googlesource.com/96636 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
The extra build can't be required, because it is not run for the build of the first GOARCH later in the loop. Tests run fine without it. Change-Id: Ida27e31ace2417192cce06c2efc93fa0d357012e Reviewed-on: https://go-review.googlesource.com/98975 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
The output takes up many lines and obscures other test output from go test -v. Change-Id: I0896717db3ce287f9e4b4263451475c19758b0e3 Reviewed-on: https://go-review.googlesource.com/99778 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
In the spirit of CL 99955, fix all non-standard generated code headers and re-run the generators. Some generated files needed git gofmt afterwards, but that problem is left for now. Change-Id: I6b3131fb1753dc427d05af03107031120755cab0 Reviewed-on: https://go-review.googlesource.com/99975 Reviewed-by: Brad Fitzpatrick <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
The default ObjC prefix and Java package have been the empty string for a while, but the gomobile bind -help text wasn't updated. Change-Id: I8acb265ae7385121fae4c2cc314220d97575d20c Reviewed-on: https://go-review.googlesource.com/99317 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Updates golang/go#24185 Change-Id: I1ce066be52feff5d2372633776aa631e0ce7e713 Reviewed-on: https://go-review.googlesource.com/100684 Reviewed-by: Ian Lance Taylor <[email protected]>
The gobind command is about to get more powerful and able to generate complete and standalone bindings. Platform specific build tags based on GOOS or GOARCH are now meaningless to generate bindings from, so remove them from the test packages. The tags mattered to the reverse bound packages, since the go tool can't build them without the Go wrappers for the imported Java packages. Before this CL, the `android` tag was used to fool the go tool since the host GOOS is unlikely to be android. A fix is to check in the generated Go wrappers, but since the packages are for testing we don't want that. Instead, move the test packages to the testdata directory so the go tool ignores them. Change-Id: I57178e930a400f690ebd7a65758bed894eeb10b0 Reviewed-on: https://go-review.googlesource.com/99315 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
The gobind and gomobile bind tools have historically overlapped: gobind outputs generated bindings, and gomobile bind will generate bindings before building them. However, the gobind bindings were never used for building and thus allowed to not be complete. To simplify version control, debugging, instrumentation and build system flexibility, this CL upgrades the gobind tool to be the canonical binding generator and change gomobile bind to use gobind instead of its own generator code. This greatly simplifies gomobile bind, but also paves the way to skip gomobile bind entirely. For example: $ gobind -outdir=$GOPATH golang.org/x/mobile/example/bind/hello $ GOOS=android GOARCH=arm64 CC=<ndk-toolchain>/bin/clang go build -buildmode=c-shared -o libgobind.so gobind $ ls libgobind.* libgobind.h libgobind.so The same applies to iOS, although the go build command line is more involved. By skipping gomobile it is possible to freely customize the Android or iOS SDK level or any other flags not supported by gomobile bind. By checking in the generated source code, the cost of supporting gomobile in a custom build system is also decreased. Change-Id: I59c14a77d625ac1377c23b3213672e0d83a48c85 Reviewed-on: https://go-review.googlesource.com/99316 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Gobind now outputs Java sources to the java/ subdirectory. Update the gradle plugin to match. Only projects using reverse bindings are affected. Change-Id: Id7f893d3c67a9ab63336c4e031c9196a0b6dad2c Reviewed-on: https://go-review.googlesource.com/99775 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
The reverse bindings allow access to Java and ObjC APIs by importing Java/... and Objc/... package from Go. The gobind tool automatically create the bindings for the API referenced from the packages. The reverse example takes that ability too far, however. It creates a circular dependency from the Android databinding layout files to exported Go types while those same Go types access the Java classes generated by databinding. It works almost by accident, but not for newer Gradle versions. The circular dependencies are bad, but the underlying circular references created by using the reverse bindings this way are worse. I haven't found a satisfactory was to avoid retaining references to Go objects from Java and back without carefully and manually breaking cycles at appropriate times. One might succeed in ObjC where breaking reference cycles are already necessary, but not in Java. The reverse example is a nice technical feat, but promises more than it can deliver. Delete it. Fixes golang/go#19862 Fixes golang/go#18210 Change-Id: Ie6abd2a0ebd4c4ce36339d1294898e15f22f83bd Reviewed-on: https://go-review.googlesource.com/101155 Reviewed-by: Brad Fitzpatrick <[email protected]>
If ever the gobind tool switches to a source importer (see CL 99777), make sure import paths are without trailing slashes are handled correctly. Change-Id: Ib3ce15f8dcd53dce09a5bb183e4013a5deba39b4 Reviewed-on: https://go-review.googlesource.com/99776 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
While we're here, sort the keyword list. Fixes golang/go#22875 Change-Id: I31844c3d66f959bb0dc47eb3062e41f75d7b765e Reviewed-on: https://go-review.googlesource.com/100795 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Fixes golang/go#21523 Change-Id: I1244e296ac4eeb0d10847e73216e4a25a3533292 Reviewed-on: https://go-review.googlesource.com/101115 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Fixes golang/go#21552 Change-Id: Id01434271916ddc489eb5f7d8355d9519885eaf4 Reviewed-on: https://go-review.googlesource.com/101116 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Fixes golang/go#18536 Change-Id: I82c5993547e4d1d0df14726ccc569e1f57128072 Reviewed-on: https://go-review.googlesource.com/101156 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Move the benchmark support package to the testdata directory, just like the other test packages. Change-Id: Idc35ca973a7da78e8c8bb640ba60cfb947fbed5b Reviewed-on: https://go-review.googlesource.com/101896 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
gomobile checks "golang.org/x/mobile/..." packages are included in the build product using nm. If "golang/x/mobile/..." package is placed under vendor directory, this check fails and it is treated as a build failure. Fixes golang/go#22152 Change-Id: Ie0e05c3e0340b3608de5c68bb3f852d4ef7cdeb1 Reviewed-on: https://go-review.googlesource.com/102095 Reviewed-by: Elias Naur <[email protected]>
Issue golang/go#24058 demonstrates a Go package that fails to build with gomobile but builds successfully with a manually using the standalone NDK toolchain. I haven't been able to figure out a set of CPPFLAGS/LDFLAGS that fixes the build for 24058 so instead rework gomobile to use standalone NDK toolchains. Standalone toolchains fixes the 24058 build and is the official way to build Android programs. So gomobile should be less affected by future changes in the NDK toolchain internals. Create the standalone toolchains with gomobile init. With the new Go 1.10 build cache, the prebuild work by the gomobile init command is useless. Use the opportunity to simplify init to only creating NDK toolchains and, optionally, building OpenAL for Android. With that, it is no longer necessary to use gomobile init to build iOS apps and frameworks. Fixes golang/go#24058 Change-Id: I4692fcaa927e7076a6387d080ebc1726905afd72 Reviewed-on: https://go-review.googlesource.com/99875 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
When running gomobile bind, make sure gobind exists. If not, instruct the user to run gomobile init which will go install gobind. Change-Id: I2d064ba58874fd5581c17417124561f3d1fb6b83 Reviewed-on: https://go-review.googlesource.com/101055 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Change-Id: Ib2d256f59ec759100f8c25e52acf24547a6528fb Reviewed-on: https://go-review.googlesource.com/c/mobile/+/489735 Auto-Submit: Ian Lance Taylor <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Run-TryBot: shuang cui <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
Fixes golang/go#59803 Change-Id: I248ab312eedf091bbfd6ebf35c8990fbdf611fbc GitHub-Last-Rev: c61def7 GitHub-Pull-Request: #91 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/488555 TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Hajime Hoshi <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> Run-TryBot: Dmitri Shuralyov <[email protected]>
This picks up CL 516917 to fix test failures in cmd/gobind. For golang/go#61035. Change-Id: Ibecb7ace6ce9133a25559191ee6075bbb714a7d7 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/520835 Reviewed-by: Robert Findley <[email protected]> Reviewed-by: Cuong Manh Le <[email protected]> Run-TryBot: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Auto-Submit: Bryan Mills <[email protected]>
Change-Id: I3a3142fdd85870473d28376451d31f4f49718023 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/525075 Run-TryBot: Hajime Hoshi <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Auto-Submit: Hajime Hoshi <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Fixes golang/go#62415 Change-Id: Ica46a62f60b8ebcf6244da98fe4e0643206cb24f Reviewed-on: https://go-review.googlesource.com/c/mobile/+/525095 Reviewed-by: Dmitri Shuralyov <[email protected]> Run-TryBot: Hajime Hoshi <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Auto-Submit: Hajime Hoshi <[email protected]> Reviewed-by: Bryan Mills <[email protected]>
go.mod files are automatically generated in a temporary working directory in order to resolve dependencies. The go.mod files didn't include go statements, which means a Go compiler tried to resolve dependencies in the most conservative way. In this way, some paths could not be resolved as ambiguous paths (e.g. golang.org/x/exp vs golang.org/x/exp/shiny). This CL fixes this issue by giving a go statement to the go.mod files. Fixes golang/go#62458 Change-Id: Ibabd1974f8cd7a3e01eb89994080e32a7115693a Reviewed-on: https://go-review.googlesource.com/c/mobile/+/525695 Run-TryBot: Hajime Hoshi <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I6fe5f820573eed19138f9ec230955e394370798f Reviewed-on: https://go-review.googlesource.com/c/mobile/+/526035 Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Gopher Robot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
On macOS, a temporary directory starts with /var, which is a symbolic link to /private/var. And in gomobile, a temporary directory is usually used as a working directly. Unfortunately, xcodebuild in Xcode 15 seems to have a bug and might not be able to understand fullpaths with symbolic links. As a workaround, resolve the path with symbolic links by filepath.EvalSymlinks. Fixes golang/go#63141 Change-Id: Ieb684223192fc3e354b79dededaecdb0b25937e6 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/530135 TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Hajime Hoshi <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Hajime Hoshi <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: Ia243abc717b04a327f90fb0db14cd40504bcf412 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/533380 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> Auto-Submit: Gopher Robot <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I4f17695a3f1568ad38c6cf63e51d2f0d58c59ffc Reviewed-on: https://go-review.googlesource.com/c/mobile/+/540821 Reviewed-by: Heschi Kreinick <[email protected]> Auto-Submit: Gopher Robot <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Carlos Amedee <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I220944631310aa41f80e4862d64df04036e7f36f Reviewed-on: https://go-review.googlesource.com/c/mobile/+/545256 LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Gopher Robot <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I5c0afe458ee23e43bc4cb0619d9297b0a7795aa1 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/555518 Auto-Submit: Gopher Robot <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Than McIntosh <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I580f00b3c82b1bc521470eddc78ef5b3a3e48300 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/563557 Auto-Submit: Gopher Robot <[email protected]> Reviewed-by: Than McIntosh <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
This change adds compatibility for Xcode 15.3 to "gomobile bind" for building xcframeworks. - New blank Info.plist in the *.framework target root - Add CFBundleExecutable and CFBundleIdentifier to the resource level Info.plist Tested locally on my framework on Xcode 15.3 (fixes issue) and 15.2 (doesn't create new issues). Would love to get some more folks to try this fix, to make sure it works broadly. Note: I'm using the framework name as the bundleID. Some chance of collision here, but didn't want to add a required top level cmd parameter. I don't *think* a collision is a serious concern, but I'm not an apple build system expert. To test: - sync my branch - build go mobile: `go build` in the `cmd/gomobile` dir - Build your xcframework with this version of go mobile: `gomobile bind ... ` - Launch a project using the xcframework in Xcode 15.3, and run in simulator Fixes golang/go#66018 Change-Id: I3e8ee99adb09071aa89a541dc97271a44b552ea3 GitHub-Last-Rev: 6277c7d GitHub-Pull-Request: #96 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/572175 TryBot-Result: Gopher Robot <[email protected]> TryBot-Bypass: Hyang-Ah Hana Kim <[email protected]> Reviewed-by: Hajime Hoshi <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Run-TryBot: Hajime Hoshi <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: Ia4925c83dad0a905dc8b74b8494a0d750fbe18be Reviewed-on: https://go-review.googlesource.com/c/mobile/+/569055 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Gopher Robot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Than McIntosh <[email protected]>
Change-Id: Ifdadb14d311a3620e499f0b33feefa3e0448a6f1 GitHub-Last-Rev: 4c346f5 GitHub-Pull-Request: #97 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/573035 Reviewed-by: Hajime Hoshi <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> Run-TryBot: Hajime Hoshi <[email protected]> TryBot-Result: Gopher Robot <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Hyang-Ah Hana Kim <[email protected]>
…orm, fixing Xcode 15.3 compatibility issues This patch updates the framework generation code to follow the Apple spec for placing content: https://developer.apple.com/documentation/bundleresources/placing_content_in_a_bundle Previously, we setup the framework in MacOS format, and used symlinks to make it compatible with iOS format. This approach no longer works (it works locally in simulator, but causes signing issues when attempting to upload apps for distribution, or running on real hardware). We now setup the expected bundle format for each platform. Other benefits: - Thirds the size of the xcframework and resulting app binary when distributing the xcframework by zip (common for SPM and other formats). The symlinks resulted in duplicate files after zipping, which made it into the final app. - Set MinimumOSVersion, fixing SPM compatibility issue - Eliminates the blank Info.plist - Initial testing shows this also fixes golang/go#66406 (code signing issues) as a side effect of using the proper format Testing: - Tested all 4 platforms (iOS, simulator, macOS, Catalyst) on Xcode 15.3 Fixes golang/go#66406 Fixes golang/go#66500 Change-Id: I8538989efe67cb0d2d0496087dcbeca923c3dffe GitHub-Last-Rev: 28dca85 GitHub-Pull-Request: #98 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/574055 Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Hajime Hoshi <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Than McIntosh <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
…ing Apple validation/distribution An app containing a framework can't be validated and distributed without these two entries in the framework bundle's `Info.plist`. Using `0.0.epoch` format per discussion here: https://go.dev/issue/66500#issuecomment-2025767017 Tested Xcode 15.3 with: - without keys, fails to validate - with keys: passing validation, distribution upload, and Apple's server validation ("Ready to test" server check). Fixes golang/go#66500 Change-Id: I2e0718247301ec7db36f8d85aea81b203ca7848b GitHub-Last-Rev: 1455c5e GitHub-Pull-Request: #100 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/575115 Reviewed-by: Dmitri Shuralyov <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> Reviewed-by: Hajime Hoshi <[email protected]> Reviewed-by: Than McIntosh <[email protected]>
Change-Id: I94b7d1c7029102c252a77f75929066281040b9f2 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/564856 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Emmanuel Odeke <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]> Auto-Submit: Hyang-Ah Hana Kim <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: Ie35799c1d449abe67ebd57c89c0d586eae5cfc02 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/576638 Auto-Submit: Gopher Robot <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Than McIntosh <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I573cd0cd9833927ef61b0c23fe30dc9140dd5696 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/583595 Auto-Submit: Gopher Robot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Than McIntosh <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
ALooper_pollAll is no longer available as of Android SDK 34. Fixes golang/go#67496 Change-Id: I1f781ef70d569df50d3059ce355a2f7d1edb435a Reviewed-on: https://go-review.googlesource.com/c/mobile/+/586595 Run-TryBot: Hajime Hoshi <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]> Auto-Submit: Hajime Hoshi <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I8374c5df7d1cade76e1898b1d6377edd8c26537a Reviewed-on: https://go-review.googlesource.com/c/mobile/+/590455 Auto-Submit: Gopher Robot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Michael Knyszek <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I86ba44822d818d83ac6f24d3456b12a37a974dda Reviewed-on: https://go-review.googlesource.com/c/mobile/+/596996 Reviewed-by: Dmitri Shuralyov <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Than McIntosh <[email protected]> Auto-Submit: Gopher Robot <[email protected]>
Very minor tweaks: - Remove (c) pseudosymbol. - Remove "All Rights Reserved." - Change "Google Inc." (no longer exists) to "Google LLC". [git-generate] echo ' ,s/\(c\) // ,s/ All rights reserved.// ,s/Google Inc./Google LLC/ w q ' | sam -d LICENSE Change-Id: Ib9d60f53433c8e92a0968c2b6d920876b5f7e7e9 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/598523 LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Russ Cox <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: Id31b88c1c74c05ce63204c3a833ef554ec296112 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/603616 LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Gopher Robot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: David Chase <[email protected]>
There's some similarity here to the situation in CL 610676. The calls
that now look like g.Printf("%s", something) would perhaps be better
expressed like g.Print(something) or g.WriteString(something), but
that's a bigger potential change to consider. This is a minimal fix.
For golang/go#69267.
Change-Id: I9cf23aef7bf2b9d9c7e9dcf3b48ecb23231016dd
Reviewed-on: https://go-review.googlesource.com/c/mobile/+/610800
Reviewed-by: Tim King <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I47a97af459b0151af8af9df1bed5ee25312579a9 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/611936 Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: David Chase <[email protected]> TryBot-Bypass: Dmitri Shuralyov <[email protected]> Auto-Submit: Gopher Robot <[email protected]>
The iOS implementation was just copied from the desktop version, and had and extra directory 'assets'. Also, files had an incorrect assumption that Arm Darwin should be an iOS. This change addresses these issues. Fixes golang/go#37177 Change-Id: I8e4de5337fbbe0b7697a8d519c8bded783399244 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/616655 Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Hyang-Ah Hana Kim <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: Ieee46df13d96ef0bc2be98e40f38f58c73131bcc Reviewed-on: https://go-review.googlesource.com/c/mobile/+/617960 Reviewed-by: Dmitri Shuralyov <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Gopher Robot <[email protected]> Reviewed-by: David Chase <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.