Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aws KMS acceptance test fix #910

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Aws KMS acceptance test fix #910

merged 2 commits into from
Sep 12, 2023

Conversation

jframe
Copy link
Contributor

@jframe jframe commented Sep 12, 2023 •
edited
Loading

PR Description

Fix AWK KMS tests failing. This was caused by a change in the test fixtures that now honors the enabled flag. Before the test fixture for AwsParameters always returned false for isEnabled.

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

siladu
siladu approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jframe jframe enabled auto-merge (squash) September 12, 2023 05:25
@jframe jframe disabled auto-merge September 12, 2023 05:31
@jframe jframe merged commit 72a2318 into Consensys:master Sep 12, 2023
@jframe jframe deleted the aws_kms_at_fix branch September 12, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siladu siladu siladu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jframe @siladu