Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --validator-ids option from watermark-repair subcommand #909

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Remove --validator-ids option from watermark-repair subcommand #909

merged 4 commits into from
Sep 12, 2023

Conversation

siladu
Copy link
Contributor

@siladu siladu commented Sep 12, 2023 •
edited
Loading

Updating a subset validators is not a used feature as far as we know.

This ensures all validators are updated by the subcommand. Preparing for adding high-watermark features to the watermark-repair subcommand.

Part of #696

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

@siladu
Remove --validator-ids option from watermark-repair subcommand
c31be40 
This ensures all validators are updated by the subcommand.
Preparing for adding high-watermark features to the watermark-repair subcommand.
@siladu siladu added the doc-change-required Indicates an issue or PR that requires doc to be updated label Sep 12, 2023
gfukushima
gfukushima approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@gfukushima gfukushima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jframe
jframe approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siladu siladu enabled auto-merge (squash) September 12, 2023 05:50
@siladu siladu merged commit a383c32 into Consensys:master Sep 12, 2023
@siladu siladu deleted the remove-watermark-repair-validator-ids branch September 12, 2023 06:09
@alexandratran alexandratran mentioned this pull request Sep 12, 2023
Closed
@alexandratran alexandratran removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfukushima gfukushima gfukushima approved these changes

@jframe jframe jframe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siladu @jframe @gfukushima @alexandratran