Aws bulk loading #889
Merged
Aws bulk loading #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
signing/src/main/java/tech/pegasys/web3signer/signing/secp256k1/aws/AwsKmsClient.java
Fixed
Show fixed
Hide fixed
…ild the AwsCredentials itself so all the building code for the credentials can be in one place
siladu
reviewed
Sep 4, 2023
...ance-tests/src/test/java/tech/pegasys/web3signer/tests/bulkloading/AwsKmsAcceptanceTest.java
Outdated
Show resolved
Hide resolved
...ance-tests/src/test/java/tech/pegasys/web3signer/tests/bulkloading/AwsKmsAcceptanceTest.java
Outdated
Show resolved
Hide resolved
commandline/src/main/java/tech/pegasys/web3signer/commandline/PicoCliAwsKmsParameters.java
Show resolved
Hide resolved
signing/src/main/java/tech/pegasys/web3signer/signing/bulkloading/BlsAwsBulkLoader.java
Show resolved
Hide resolved
signing/src/main/java/tech/pegasys/web3signer/signing/secp256k1/aws/AwsKmsClient.java
Outdated
Show resolved
Hide resolved
...g/src/main/java/tech/pegasys/web3signer/signing/secp256k1/aws/CachedAwsKmsClientFactory.java
Outdated
Show resolved
Hide resolved
signing/src/test/java/tech/pegasys/web3signer/signing/secp256k1/aws/AwsKmsClientTest.java
Outdated
Show resolved
Hide resolved
…ission on some keys to list tags
gfukushima
reviewed
Sep 4, 2023
signing/src/main/java/tech/pegasys/web3signer/signing/config/AwsParameters.java
Outdated
Show resolved
Hide resolved
jframe
added
the
doc-change-required
…nged the params to be disabled to remove noise from tests.
|
Still LGTM ✅ |
alexandratran
removed
the
doc-change-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Adds support for bulk loading of secp256k1 keys in AWS for Eth1 mode. This allows for easier configuration when using AWS KMS for storing keys when using transaction signing.
This adds the following new command line options. These are similar in meaning the aws parameters in Eth2 mode.
Fixed Issue(s)
fixes #770
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Testing