feat: Commit boost API - Generate Proxy Key #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- Added routes and handler -- Added acceptance test
usmansaleem
added
the
TeamCerberus
jframe
reviewed
Nov 27, 2024
Comment on lines
39
to
41
| private static final int NOT_FOUND = 404; | ||
| private static final int BAD_REQUEST = 400; | ||
| private static final int INTERNAL_ERROR = 500; |
There was a problem hiding this comment.
These should be defined somewhere common, so they don't need to be redefined again
There was a problem hiding this comment.
We might be able to reuse Vertx constants.
| .end( | ||
| new JsonObject() | ||
| .put("code", statusCode) | ||
| .put("message", "Identifier not found.") |
There was a problem hiding this comment.
Not sure how strict commit boost is on the error message, but the API specifies the message of "Unknown pubkey" for a 404 on this page https://commit-boost.github.io/commit-boost-client/api/
| .end( | ||
| new JsonObject() | ||
| .put("code", statusCode) | ||
| .put("message", "Internal Server Error") |
There was a problem hiding this comment.
Not sure how strict commit boost is on the error message, but the API specifies the message of "Internal error" for a 500 on this page https://commit-boost.github.io/commit-boost-client/api/
.../java/tech/pegasys/web3signer/core/service/http/handlers/commitboost/ProxyKeysGenerator.java
Show resolved
Hide resolved
...ys/web3signer/core/service/http/handlers/commitboost/CommitBoostGenerateProxyKeyHandler.java
Show resolved
Hide resolved
jframe
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Commit boost API - Generate Proxy Key Implementation of https://commit-boost.github.io/commit-boost-client/api
Fixed Issue(s)
See #1017
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Testing