Added trusted-setup cli arg back in for teku acceptance testing #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think ultimately this should be less important at some point but if it's present it allows me to actually test some changes now, rather than waiting for future builds that build in some changes to teku that remove the need to define trustedSetup, so ideally it's ok to have this defined as a dev flag for testing for now... The problem I was having was acceptance-tests use custom configuration and there was no way to specify this argument, so I wasn't able to check deneb for external-signer changes in teku... I've got another change for teku that should make this less important again (default trusted-setup basically) but it'll be hard to coordinate that change plus external-signer changes without some blocking, unless this flag exists, and then i can just start testing things now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think ultimately this should be less important at some point but if it's present it allows me to actually test some changes now, rather than waiting for future builds that build in some changes to teku that remove the need to define trustedSetup, so ideally it's ok to have this defined as a dev flag for testing for now...
The problem I was having was acceptance-tests use custom configuration and there was no way to specify this argument, so I wasn't able to check deneb for external-signer changes in teku...
I've got another change for teku that should make this less important again (default trusted-setup basically) but it'll be hard to coordinate that change plus external-signer changes without some blocking, unless this flag exists, and then i can just start testing things now.
Given this is hidden i didn't add it to changelog but happy to if needed... The only place calling it will be a teku acceptance test once i merge that...
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Testing