Transition finalized state until the first slot after the finalized epoch #8782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Fukushima <[email protected]>
Signed-off-by: Gabriel Fukushima <[email protected]>
…pty blocks Signed-off-by: Gabriel Fukushima <[email protected]>
zilm13
reviewed
Oct 24, 2024
| true))); | ||
| finalized -> { | ||
| final UInt64 slot = finalized.getSlot(); | ||
| final Spec spec = finalized.getSpec(); |
There was a problem hiding this comment.
we have spec already at StateSelectorFactory
There was a problem hiding this comment.
how did I miss that?
| final BeaconState finalizedState; | ||
| //if this isn't the first slot after the finalized epoch than | ||
| // we'll compute empty slots until we get there | ||
| if (!slot.dividedBy(spec.getSlotsPerEpoch(slot)).isZero()) { |
There was a problem hiding this comment.
I'd avoid checks like this especially we consider changes in slots time or maybe slots per epoch in the future. Use spec helpers like computeStartSlotAtEpoch and compare actual and expected slot
There was a problem hiding this comment.
yeah, that is much better, thanks for the heads up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR aims to return the finalized state applying processing empty slot to make the transtion of the epoch fixing the case when we return a different state when the first slot of the new epoch is an empty block.
Missing some unit tests but tests with kurtosis have shown good results.
Fixed Issue(s)
Fixes #7955
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog