-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO MERGE] PoC Dagger DI as a system builder #8411
Draft
Nashatyrev
wants to merge
28
commits into
Consensys:master
Choose a base branch
from
Nashatyrev:experiment/dagger-beacon-chain
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[NO MERGE] PoC Dagger DI as a system builder #8411
Nashatyrev
wants to merge
28
commits into
Consensys:master
from
Nashatyrev:experiment/dagger-beacon-chain
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen other services are started
…ata initialization so we need to add this dummy dependency
services/beaconchain/src/main/java/tech/pegasys/teku/services/beaconchain/init/MainModule.java
Dismissed
Show dismissed
Hide dismissed
services/beaconchain/src/main/java/tech/pegasys/teku/services/beaconchain/init/MainModule.java
Dismissed
Show dismissed
Hide dismissed
services/beaconchain/src/main/java/tech/pegasys/teku/services/beaconchain/init/MainModule.java
Dismissed
Show dismissed
Hide dismissed
services/beaconchain/src/main/java/tech/pegasys/teku/services/beaconchain/init/MainModule.java
Dismissed
Show dismissed
Hide dismissed
services/beaconchain/src/main/java/tech/pegasys/teku/services/beaconchain/init/MainModule.java
Dismissed
Show dismissed
Hide dismissed
services/beaconchain/src/main/java/tech/pegasys/teku/services/beaconchain/init/MainModule.java
Dismissed
Show dismissed
Hide dismissed
services/beaconchain/src/main/java/tech/pegasys/teku/services/beaconchain/init/MainModule.java
Dismissed
Show dismissed
Hide dismissed
...ces/beaconchain/src/main/java/tech/pegasys/teku/services/beaconchain/init/StorageModule.java
Dismissed
Show dismissed
Hide dismissed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This is PoC on how the Google Dagger compile time Dependency Injection library could be used to build up the Teku components together.
This PR demonstrates the concept by building
BeaconChainController
in a modular fashion with clear dependencies for every small subcomponent.Pros of Dagger approach:
Eth2Network
) is assembled from smaller subcomponents (DiscoveryNetwork
,Eth2PeerManager
, etc.) but there is no need for a larger component to care about passing parameters to its subcomponentsBeaconChainController
initializationLazy
dependencies)Cons:
As an experiment I have also created a draft Dagger builder for the networking components in this branch
TODOs:
BeaconChainController
SafeFuture.join()
. Dagger has the extension 'Producers' which deals asynchronously with all the dependecies. Worth trying to adopt it.Set<VoidInitializer>
dependecy for a top levelServiceStarter
component. Probably there is a better approach.EventChannelSubscriber
s to their constructors/buildersLazy
is used in 2 distinct contexts:Lazy
doesn't perform loop checking during compile time, however in the second case it makes sense and worth to be doneBLS
dependency instead of static instanceDocumentation
doc-change-required
label to this PR if updates are required.Changelog