Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sf-598 estimate gas fee with txn v3 #220

Closed
wants to merge 6 commits into from

Conversation

stanleyyconsensys
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys commented Mar 26, 2024

This PR is to allow RPC method starkNet_estimateFee to be completable with TXN v3

it take an extra parameter priceUnit to indicate the requested rpc is looking for Wei Estimation or Fri Estimation
where Wei is the default value

it has dependency on

RPC call example:

{
  method: 'wallet_invokeSnap',
  params: {
    snapId: '[SNAP_ID]',
    request: {
      method: 'starkNet_estimateFee',
      params: {
        // ... existing implementation 
        priceUnit: "FRI" // FRI or WEI,
      }
    }
  }
}

Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Failed Quality Gate failed for 'consensys_starknet-snap-starknet-snap'

Failed conditions
68.2% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant