Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency updates #32

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Dependency updates #32

merged 4 commits into from
Jan 22, 2024

Conversation

blitz-1306
Copy link
Contributor

@blitz-1306 blitz-1306 commented Jan 22, 2024

Note

This PR also fixes #29 and fixes #31. No issues were found via npm audit.

Changes

  • Updated dependencies (except VM-related ones).
  • Use jest instead of mocha + nyc.
  • Use NodeJS 20 (LTS).
  • Move fs-extra to package dependencies instead of devDependencies (as it is used in the code-base).

Note

Branch coverage dropped to 68 instead from 70 due to coverage computation differences. This is a side-effect.

Regards.

@blitz-1306 blitz-1306 added the dependencies Pull requests that update a dependency file label Jan 22, 2024
@blitz-1306 blitz-1306 requested a review from cd1m0 January 22, 2024 05:26
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (2492dde) 76.08% compared to head (cc60ab1) 77.89%.

Files Patch % Lines
src/artifacts/helpers.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   76.08%   77.89%   +1.81%     
==========================================
  Files          22       22              
  Lines        2199     2199              
  Branches      455      455              
==========================================
+ Hits         1673     1713      +40     
- Misses        331      422      +91     
+ Partials      195       64     -131     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@cd1m0 cd1m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cd1m0 cd1m0 merged commit 92949b1 into main Jan 22, 2024
2 checks passed
@cd1m0 cd1m0 deleted the update-deps branch January 22, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants