Build native lib for arm64 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
|
The docker images look heavier than usual, especially the windows one |
|
These Docker images are only used to cross compile, they are not published and are not the final artifact, that is the jar file |
|
What is the best way to test in this case ? |
|
If I understand correctly, the jar will include both ARM64 and AMD64 library (libcompress_jni.so) thanks to cross plateform compilation. Is that correct ? |
|
Added a doc in the README on how to release native libs locally, and yes the published jar will contain all the built native libs |
Signed-off-by: Fabio Di Fabio <[email protected]>
ahamlat
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Dockercross to compile the native lib for different platform and architecture, include arm64.