Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prover/feat/Adding field extension support to Smartvectors #499

Draft
wants to merge 73 commits into
base: main
Choose a base branch
from

Conversation

bogdanbear
Copy link
Contributor

@bogdanbear bogdanbear commented Jan 7, 2025

This PR completes the work concerning smartvectors and associated packages Issue 474, concerning the prover transition to a mixture of base fields and field extensions.

Checklist

  • Updated the field extension mock.
  • Completed the smartvector functionality for the field extension case.
  • Unit testing.

@bogdanbear bogdanbear self-assigned this Jan 7, 2025
Copy link

cla-assistant bot commented Jan 7, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Jan 7, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 68.40491% with 103 lines in your changes missing coverage. Please review.

Project coverage is 68.75%. Comparing base (27cc9eb) to head (4fa3996).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...s/linea/testing/submission/SubmissionTestHelper.kt 0.00% 19 Missing ⚠️
...s/src/main/kotlin/linea/web3j/Web3JLogsSearcher.kt 81.55% 15 Missing and 4 partials ⚠️
...in/kotlin/linea/coordinator/config/ConfigLoader.kt 69.09% 9 Missing and 8 partials ⚠️
...src/main/kotlin/linea/logging/TimeMeasureLogger.kt 0.00% 16 Missing ⚠️
...nsensys/zkevm/coordinator/app/CoordinatorAppCli.kt 0.00% 8 Missing ⚠️
.../consensys/zkevm/coordinator/app/L1DependentApp.kt 0.00% 6 Missing ⚠️
...models/src/main/kotlin/linea/domain/RetryConfig.kt 80.00% 2 Missing and 2 partials ⚠️
...nsensys/linea/contract/Web3JContractAsyncHelper.kt 0.00% 0 Missing and 3 partials ⚠️
...essor/src/main/kotlin/linea/blob/BlobCompressor.kt 0.00% 3 Missing ⚠️
...nsions/src/main/kotlin/linea/web3j/SearchCursor.kt 92.10% 1 Missing and 2 partials ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #499      +/-   ##
============================================
+ Coverage     68.18%   68.75%   +0.57%     
- Complexity     1129     1166      +37     
============================================
  Files           320      326       +6     
  Lines         12858    13039     +181     
  Branches       1292     1312      +20     
============================================
+ Hits           8767     8965     +198     
+ Misses         3560     3526      -34     
- Partials        531      548      +17     
Flag Coverage Δ
hardhat 98.74% <0.00%> (ø)
kotlin 66.37% <68.61%> (+0.65%) ⬆️
Files with missing lines Coverage Δ
...kevm/coordinator/app/LastFinalizedBlockProvider.kt 96.42% <100.00%> (-0.72%) ⬇️
...clients/prover/FileBasedExecutionProverClientV2.kt 59.01% <100.00%> (ø)
.../linea/contract/Web3JL2MessageServiceLogsClient.kt 26.31% <ø> (ø)
...ys/zkevm/ethereum/submission/SwitchProviderImpl.kt 82.75% <ø> (ø)
...reum/gaspricing/staticcap/FeeHistoryFetcherImpl.kt 84.61% <ø> (-5.96%) ⬇️
...lin/net/consensys/zkevm/ethereum/AccountManager.kt 73.84% <100.00%> (-1.54%) ⬇️
...src/main/kotlin/net/consensys/TypingsExtensions.kt 80.95% <100.00%> (+2.57%) ⬆️
...nsys/linea/logging/JsonRpcRequestResponseLogger.kt 97.22% <100.00%> (+0.25%) ⬆️
...uild/linea/s11n/jackson/InstantAsHexNumberSerDe.kt 100.00% <100.00%> (ø)
...in/build/linea/s11n/jackson/InstantISO8601SerDe.kt 100.00% <ø> (ø)
... and 15 more

... and 8 files with indirect coverage changes

* initial implementaiton of the wrapper

* started updating the gnark interpolation
@bogdanbear bogdanbear requested a review from a team as a code owner January 17, 2025 11:44
@bogdanbear bogdanbear temporarily deployed to docker-build-and-e2e January 17, 2025 11:48 — with GitHub Actions Inactive
@bogdanbear bogdanbear temporarily deployed to docker-build-and-e2e January 17, 2025 13:20 — with GitHub Actions Inactive
@bogdanbear bogdanbear marked this pull request as draft January 17, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants