Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] 4.9 - Use encodeCall vs encodeWithSelector #414

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thedarkjester
Copy link
Collaborator

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@thedarkjester thedarkjester requested a review from a team as a code owner December 10, 2024 09:24
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.17%. Comparing base (8cf2866) to head (8762472).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #414   +/-   ##
=========================================
  Coverage     70.17%   70.17%           
  Complexity     1070     1070           
=========================================
  Files           306      306           
  Lines         12337    12337           
  Branches       1179     1179           
=========================================
  Hits           8658     8658           
  Misses         3200     3200           
  Partials        479      479           
Flag Coverage Δ *Carryforward flag
hardhat 98.70% <ø> (ø)
kotlin 67.86% <ø> (ø) Carriedforward from 8cf2866

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
contracts/contracts/ZkEvmV2.sol 100.00% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants