Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinator: replace teku ExecutionPlayloadV1 by Domain Block class - fix block encoding #406

Merged
merged 34 commits into from
Dec 16, 2024

Conversation

jpnovais
Copy link
Collaborator

@jpnovais jpnovais commented Dec 6, 2024

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@jpnovais jpnovais requested a review from a team December 6, 2024 19:17
@jpnovais jpnovais temporarily deployed to docker-build-and-e2e December 6, 2024 19:18 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 33.98438% with 507 lines in your changes missing coverage. Please review.

Project coverage is 68.16%. Comparing base (eafe687) to head (91030c8).

Files with missing lines Patch % Lines
.../kotlin/linea/rlp/NoSignatureTransactionDecoder.kt 0.00% 92 Missing ⚠️
...omain-models/src/main/kotlin/linea/domain/Block.kt 25.68% 79 Missing and 2 partials ⚠️
...models/src/main/kotlin/linea/domain/Transaction.kt 35.45% 46 Missing and 25 partials ⚠️
...essor/src/main/kotlin/linea/blob/BlobCompressor.kt 0.00% 47 Missing ⚠️
...ain/kotlin/linea/domain/MapperLineaDomainToBesu.kt 45.12% 40 Missing and 5 partials ⚠️
...ain/kotlin/linea/domain/MapperBesuToLineaDomain.kt 0.00% 41 Missing ⚠️
...src/main/kotlin/linea/rlp/BesuRlpMainnetEncoder.kt 0.00% 21 Missing ⚠️
...u-rlp-and-mappers/src/main/kotlin/linea/rlp/RLP.kt 0.00% 18 Missing ⚠️
...rs/src/main/kotlin/linea/rlp/BesuRlpBlobDecoder.kt 0.00% 17 Missing ⚠️
.../coordinator/blockcreation/BlockCreationMonitor.kt 58.62% 8 Missing and 4 partials ⚠️
... and 21 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #406      +/-   ##
============================================
- Coverage     70.17%   68.16%   -2.01%     
- Complexity     1070     1125      +55     
============================================
  Files           306      319      +13     
  Lines         12338    12789     +451     
  Branches       1179     1275      +96     
============================================
+ Hits           8658     8718      +60     
- Misses         3201     3542     +341     
- Partials        479      529      +50     
Flag Coverage Δ *Carryforward flag
hardhat 98.59% <ø> (ø) Carriedforward from 64c1543
kotlin 65.79% <33.98%> (-2.08%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
.../consensys/zkevm/coordinator/app/CoordinatorApp.kt 0.00% <ø> (ø)
...clients/prover/FileBasedExecutionProverClientV2.kt 59.01% <100.00%> (ø)
...dination/blockcreation/BlockCreationCoordinator.kt 100.00% <100.00%> (ø)
...on/conflation/BlockToBatchSubmissionCoordinator.kt 91.66% <100.00%> (-0.23%) ⬇️
...conflation/upgrade/SwitchAwareConflationHandler.kt 100.00% <100.00%> (ø)
.../src/main/kotlin/net/consensys/StringExtensions.kt 85.71% <100.00%> (+19.04%) ⬆️
...src/main/kotlin/net/consensys/TypingsExtensions.kt 78.37% <100.00%> (ø)
...consensys/linea/jsonrpc/JsonRpcMessageProcessor.kt 90.60% <100.00%> (+2.49%) ⬆️
...nsys/zkevm/ethereum/coordination/MaxLongTracker.kt 19.23% <0.00%> (ø)
...um/coordination/blockcreation/SafeBlockProvider.kt 0.00% <0.00%> (-19.05%) ⬇️
... and 29 more

... and 10 files with indirect coverage changes

@jpnovais jpnovais temporarily deployed to docker-build-and-e2e December 6, 2024 20:11 — with GitHub Actions Inactive
@jpnovais jpnovais temporarily deployed to docker-build-and-e2e December 6, 2024 22:39 — with GitHub Actions Inactive
@jpnovais jpnovais force-pushed the coordinator-fix-blockencoding branch from b8a6102 to adf559c Compare December 9, 2024 18:41
@jpnovais jpnovais temporarily deployed to docker-build-and-e2e December 9, 2024 18:43 — with GitHub Actions Inactive
build.gradle Outdated Show resolved Hide resolved
…r/blockcreation/BlockCreationMonitor.kt

Co-authored-by: Roman Vaseev <[email protected]>
Signed-off-by: Pedro Novais <[email protected]>
@jpnovais jpnovais temporarily deployed to docker-build-and-e2e December 16, 2024 14:44 — with GitHub Actions Inactive
@jpnovais jpnovais temporarily deployed to docker-build-and-e2e December 16, 2024 15:44 — with GitHub Actions Inactive
@jpnovais jpnovais requested a review from Filter94 December 16, 2024 16:33
@jpnovais jpnovais temporarily deployed to docker-build-and-e2e December 16, 2024 16:33 — with GitHub Actions Inactive
@jpnovais jpnovais merged commit 829630b into main Dec 16, 2024
26 checks passed
@jpnovais jpnovais deleted the coordinator-fix-blockencoding branch December 16, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants