feat: rewrite error logs from blob submission eth_call due to insuffi… #157
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
=========================================
Coverage 67.84% 67.85%
Complexity 1040 1040
=========================================
Files 248 248
Lines 10391 10396 +5
Branches 867 870 +3
=========================================
+ Hits 7050 7054 +4
Misses 2874 2874
- Partials 467 468 +1
|
…price during blob submission eth_call
| isEthCall = true | ||
| ) | ||
| val expectedErrorMessage = | ||
| "max fee per gas less than block base fee:" + |
There was a problem hiding this comment.
we should keep the original terminology maxFeePerGas. Likewise in the other places as well.
There was a problem hiding this comment.
If we'd like to keep the original terminology maxFeePerGas, I'd also do the same for maxFeePerBlobGas
config/coordinator/log4j2-dev.xml
Outdated
| @@ -28,6 +28,7 @@ | |||
| <KnownError logLevel="DEBUG" message="^.*?\bConnection reset\b.*?$" stackTrace="true" /> | |||
| <KnownError logLevel="INFO" message="^.*?\beth_call\b.*?\bContract Call has been reverted by the EVM with the reason\b.*?$"/> | |||
| <KnownError logLevel="INFO" message="^.*?\brequest beyond head block\b.*?$"/> | |||
| <KnownError logLevel="INFO" message="^.*?\beth_call for blob submission failed\b.*?\bmax fee per (blob )?gas less than block (blob gas|base) fee\b.*?$"/> | |||
There was a problem hiding this comment.
This log level shall be addressed in the code IMO. Not, by configuration.
The configuration shall be used as a "quick fix/workaround" in prod until the log is is fixed in the code.
There was a problem hiding this comment.
This is to let the log rewriter to set the log level to INFO instead of ERROR for the reformatted error message given that the one in line 29 won't be working for insufficent gas fee error after the error message get reformatted.
My initial thought is to align the use of log rewriter to re-set the log level, but I also think, for simplicity, we could just call log.info() in LoggingHelper if eth_call blob submission insufficent gas fee error is detected. If no objection, I'd change that to be handled in LoggingHelper
…pdate rewrite wordings
…cient gas prices
This PR implements issue(s) #
Checklist