Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the bug in the permutation #155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Soleimani193
Copy link
Contributor

This PR addresses an issue in the permutation-query.
for the multi-column cases, the Z polynomial nominator and dominator were both built based on the same polynomial A (rather than A against B). Causing the verifier to accept false claims over multi-column cases.

More test cases are added to cover the false claims that we don't expect the verifier to accept.

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@Soleimani193 Soleimani193 marked this pull request as ready for review October 7, 2024 15:10
@Soleimani193 Soleimani193 self-assigned this Oct 7, 2024
@Soleimani193 Soleimani193 added the Prover Tag to use for all work impacting the prover label Oct 7, 2024
@Soleimani193 Soleimani193 force-pushed the prover/compiler-issue-for-permutation branch from b714e11 to 84134b3 Compare October 10, 2024 08:49
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.46%. Comparing base (d86aa9a) to head (84134b3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #155      +/-   ##
============================================
+ Coverage     70.39%   70.46%   +0.06%     
  Complexity     1040     1040              
============================================
  Files           282      282              
  Lines         11312    11314       +2     
  Branches       1082     1082              
============================================
+ Hits           7963     7972       +9     
+ Misses         2882     2875       -7     
  Partials        467      467              
Flag Coverage Δ
hardhat 98.70% <ø> (ø)
kotlin 67.94% <ø> (+0.07%) ⬆️

see 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prover Tag to use for all work impacting the prover
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants