perf: remove uneeded bucket init in affine coordinates

Consensys · Aug 27, 2024 · ef90355 · ef90355
1 parent ff4c0dd
commit ef90355
Show file tree

Hide file tree

Showing 11 changed files with 20 additions and 40 deletions.
diff --git a/ecc/bls12-377/multiexp_affine.go b/ecc/bls12-377/multiexp_affine.go
diff --git a/ecc/bls12-378/multiexp_affine.go b/ecc/bls12-378/multiexp_affine.go
diff --git a/ecc/bls12-381/multiexp_affine.go b/ecc/bls12-381/multiexp_affine.go
diff --git a/ecc/bls24-315/multiexp_affine.go b/ecc/bls24-315/multiexp_affine.go
diff --git a/ecc/bls24-317/multiexp_affine.go b/ecc/bls24-317/multiexp_affine.go
diff --git a/ecc/bn254/multiexp_affine.go b/ecc/bn254/multiexp_affine.go
diff --git a/ecc/bw6-633/multiexp_affine.go b/ecc/bw6-633/multiexp_affine.go
diff --git a/ecc/bw6-756/multiexp_affine.go b/ecc/bw6-756/multiexp_affine.go
diff --git a/ecc/bw6-761/multiexp_affine.go b/ecc/bw6-761/multiexp_affine.go
diff --git a/ecc/secp256k1/multiexp_affine.go b/ecc/secp256k1/multiexp_affine.go
diff --git a/internal/generator/ecc/template/multiexp_affine.go.tmpl b/internal/generator/ecc/template/multiexp_affine.go.tmpl
@@ -61,10 +61,9 @@ func processChunk{{ $.UPointName }}BatchAffine[BJE ib{{ $.TJacobianExtended }},B
  // note that we have 2 sets of buckets
  // 1 in {{ $.TAffine }} used with the batch affine additions
  // 1 in {{ $.TJacobianExtended }} used in case the queue of conflicting points
- var buckets B
+ var buckets B // in {{ $.TAffine }} coordinates, infinities are represented as (0,0), no need to init
  var bucketsJE BJE
  for i := 0; i < len(buckets); i++ {
- buckets[i].setInfinity()
  bucketsJE[i].setInfinity()
  }