Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added detailed guide about DipDup indexer #673

Merged
merged 7 commits into from
Aug 16, 2024
Merged

Conversation

isfriz
Copy link
Contributor

@isfriz isfriz commented Aug 6, 2024

No description provided.

Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doc-zk-evm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 8:33am

@isfriz isfriz marked this pull request as ready for review August 7, 2024 15:26
@jlwllmr
Copy link
Collaborator

jlwllmr commented Aug 15, 2024

@isfriz nice work - just the one bit of feedback in a comment, but it's not essential.

Before merging:

  • A redirect from the old path /data-indexers/dipdup will be necessary. There isn't an index file in the new /dipdup directory you created, so any user visiting the old path will 404. I suggest you add a redirect from the old path to the overview page. Redirects are in docusuarus.config.js
  • Please add pipx to the project-words.txt to pass the linter.

Thanks!

@isfriz
Copy link
Contributor Author

isfriz commented Aug 15, 2024

@isfriz nice work - just the one bit of feedback in a comment, but it's not essential.

Before merging:

  • A redirect from the old path /data-indexers/dipdup will be necessary. There isn't an index file in the new /dipdup directory you created, so any user visiting the old path will 404. I suggest you add a redirect from the old path to the overview page. Redirects are in docusuarus.config.js
  • Please add pipx to the project-words.txt to pass the linter.

Thanks!

Thx 4 review!
Done!

Copy link
Collaborator

@jlwllmr jlwllmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlwllmr jlwllmr merged commit dd595ac into Consensys:main Aug 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants