Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: erpc #670

Merged
merged 10 commits into from
Aug 27, 2024
Merged

docs: erpc #670

merged 10 commits into from
Aug 27, 2024

Conversation

kasrakhosravi
Copy link
Contributor

Adding eRPC as RPC proxy and caching for Linea

Copy link

vercel bot commented Aug 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doc-zk-evm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 9:29am

@jlwllmr
Copy link
Collaborator

jlwllmr commented Aug 15, 2024

hi @kasrakhosravi, thanks for adding this.

I would suggest that, instead of the current proposed structure (under developers/guides), we turn tooling/node-providers into a category, making the existing node-providers.md file the index page of the category, and then housing the eRPC page within this category.

Let me know your thoughts. Another alternative is having the guide in the community guides section, if you'd prefer.

@jlwllmr jlwllmr added the ecosystem Contribution by an ecosystem organisation label Aug 22, 2024
@kasrakhosravi
Copy link
Contributor Author

hi @kasrakhosravi, thanks for adding this.

I would suggest that, instead of the current proposed structure (under developers/guides), we turn tooling/node-providers into a category, making the existing node-providers.md file the index page of the category, and then housing the eRPC page within this category.

Let me know your thoughts. Another alternative is having the guide in the community guides section, if you'd prefer.

great idea. changed the dir structure for this. lmk what you think

Screenshot 2024-08-25 at 13 05 28

Copy link
Collaborator

@jlwllmr jlwllmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing @kasrakhosravi! Made a few adjustments and pushed them up. Adjusted the title of the page so that it appears as eRPC in the sidebar, which is consistent with other tooling pages and also means it fits on one line.

@jlwllmr jlwllmr merged commit 061e7e8 into Consensys:main Aug 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecosystem Contribution by an ecosystem organisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants