Support listening both IPv4 and IPv6 + NodeRecord extension #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zilm13
approved these changes
Jun 11, 2024
| this.channel = channel; | ||
| final Publisher<NetworkParcel> outgoingStream, final List<NioDatagramChannel> channels) { | ||
| this.ip4Channel = channels.stream().filter(channel -> !isChannelIPv6(channel)).findFirst(); | ||
| this.ip6Channel = channels.stream().filter(this::isChannelIPv6).findFirst(); | ||
| Flux.from(outgoingStream) |
There was a problem hiding this comment.
Shouldn't we throw here if both are empty?
There was a problem hiding this comment.
Changed the design a bit. You can have a look.
src/main/java/org/ethereum/beacon/discovery/network/NettyDiscoveryServerImpl.java
Outdated
Show resolved
Hide resolved
zilm13
reviewed
Jun 13, 2024
| this.channel = channel; | ||
| final Publisher<NetworkParcel> outgoingStream, | ||
| final Map<InternetProtocolFamily, NioDatagramChannel> channels) { | ||
| this.channels = channels; |
There was a problem hiding this comment.
I'd add throw if channels is empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
IPv6methods inNodeRecordChange CircleCI to use machine executor instead of docker as per https://circleci.com/docs/faq/#ipv6-in-tests
Fixed Issue(s)
fixes #176