支持飞书传图GitHub #231
Merged
支持飞书传图GitHub #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
freeziyou
commented
Feb 22, 2024
•
freeziyou
commented
- img_key转换成url，通过url直接调用飞书下载图片
- 权限控制(公私仓库)
Closed
lloydzhou
approved these changes
Feb 23, 2024
| else str(task.result), | ||
| "result": ( | ||
| task.result if isinstance(task.result, list) else str(task.result) | ||
| ), |
There was a problem hiding this comment.
这里改了结构，需要和前端沟通好，免得前端调用接口的时候报错
|
私有仓库 传图那个有解吗？能否先牺牲一点安全性，先考虑基本可用（比如直接把GitHub那边的图片链接发送到飞书这边来） |
|
在GitHub上放图片时，会由Github未开放的api上传到服务器(https://github.com/upload/policies/assets)，最后返回一个需要用户token验证的图片链接，正是因为Github做了安全性导致无法可用 |
|
从飞书传图到GitHub公私仓库都没问题，主要是Github私有仓库传图到飞书有问题 |
|
授权之后的GitMaya机器人也无法访问GitHub私有仓库的图片对吧？ |
|
没法访问，和林哥探索的唯一方式是拿GitHub personal user token可以访问，但这个只能由用户自己在Github手动创建token，并且权限过大，仅为看图不合理…而且测试其他包括oauth token installation token都没用 |
|
这个图片的链接可以拿到吧，直接回传到飞书呗 |
|
不上传飞书图床，直接显示原始链接url ，可行吗？ @freeziyou |
|
可以做，但这样的话，相当于飞书这边只显示图片链接没显示图片 |
lloydzhou
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.