Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint): resolve multiple eslint errors #637

Open
wants to merge 4 commits into
base: next
Choose a base branch
from

Conversation

at-wr
Copy link
Contributor

@at-wr at-wr commented Oct 20, 2024

Fixed errors

  • unused-imports/no-unused-vars
  • vue/no-use-v-if-with-v-for
  • antfu/no-top-level-await

Pre-Fix error

Link: https://github.com/Computerization/Enspire/pull/636/checks

/pages/manage/manage.vue
Error:   36:10  error  'error' is defined but never used                                                         unused-imports/no-unused-vars
Error:   50:52  error  'currentStatus' is assigned a value but never used. Allowed unused args must match /^_/u  unused-imports/no-unused-vars
Error:   63:11  error  'data' is assigned a value but never used. Allowed unused vars must match /^_/u           unused-imports/no-unused-vars

/pages/manage/statuses.vue
Error:   26:15  error  'refresh' is assigned a value but never used. Allowed unused vars must match /^_/u  unused-imports/no-unused-vars
Error:   71:60  error  This 'v-if' should be moved to the wrapper element                                  vue/no-use-v-if-with-v-for

/utils/update-classroom-data.ts
Error:   30:1  error  Do not use top-level await  antfu/no-top-level-await

fixed errors:
- unused-imports/no-unused-vars
- vue/no-use-v-if-with-v-for
- antfu/no-top-level-await
Copy link

changeset-bot bot commented Oct 20, 2024

🦋 Changeset detected

Latest commit: ee0989d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
enspire Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for enspire-staging ready!

Name Link
🔨 Latest commit ee0989d
🔍 Latest deploy log https://app.netlify.com/sites/enspire-staging/deploys/6714cfd36712dd0008f7c1d3
😎 Deploy Preview https://deploy-preview-637--enspire-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@at-wr
Copy link
Contributor Author

at-wr commented Oct 20, 2024

Conclusion, add underscore "_" before unused vars to avoid the ESLint warning.

@qwerzl
Copy link
Collaborator

qwerzl commented Oct 21, 2024

Conclusion, add underscore "_" before unused vars to avoid the ESLint warning.

I'd recommend just deleting the vars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants