-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update requirements to actually work #366
base: master
Are you sure you want to change the base?
Update requirements to actually work #366
Conversation
# This file is autogenerated by pip-compile with python 3.9 | ||
# To update, run: | ||
# This file is autogenerated by pip-compile with Python 3.11 | ||
# by the following command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the docker file, CI, and readme also using 3.11?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not a bad point, I can re-generate it with 3.9, though this requirements does work in 3.9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you need to use the same versions as we're using elsewhere, unless you want to make an effort to update everything to 3.11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just triggered CI, so we'll see what happens
Can you also base this against develop? We should only be merging to master when making prod releases, which generally is very risky this time of year, and we prefer to do from develop for consistency and dev workflow |
Yep, I was messing with branches and didn't realize that develop was the default. I'll rebase it when I move to 3.9. |
No description provided.