Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements to actually work #366

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gidoBOSSftw5731
Copy link

No description provided.

Comment on lines -2 to +3
# This file is autogenerated by pip-compile with python 3.9
# To update, run:
# This file is autogenerated by pip-compile with Python 3.11
# by the following command:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the docker file, CI, and readme also using 3.11?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not a bad point, I can re-generate it with 3.9, though this requirements does work in 3.9.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you need to use the same versions as we're using elsewhere, unless you want to make an effort to update everything to 3.11

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just triggered CI, so we'll see what happens

@mxmeinhold
Copy link
Collaborator

Can you also base this against develop? We should only be merging to master when making prod releases, which generally is very risky this time of year, and we prefer to do from develop for consistency and dev workflow

@gidoBOSSftw5731
Copy link
Author

Can you also base this against develop? We should only be merging to master when making prod releases, which generally is very risky this time of year, and we prefer to do from develop for consistency and dev workflow

Yep, I was messing with branches and didn't realize that develop was the default. I'll rebase it when I move to 3.9.

@esoccoli esoccoli added dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants