Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix collision particle invalid memory #4810

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

fix collision particle invalid memory #4810

wants to merge 1 commit into from

Conversation

psychocoderHPC
Copy link
Member

Revert partly changes from #4745 to avoid invalid memory access. Switch back to traversing the frame list for each particle access.

BUg reported by @pordyna

@psychocoderHPC
fix collision particle invalid memory
93765f0 
Revert partly changes from ComputationalRadiationPhysics#4745 to avoid invalid memory access.
Switch back to traversing the frame list for each particle access.
@psychocoderHPC psychocoderHPC added bug a bug in the project's code component: core in PIConGPU (core application) labels Feb 8, 2024
@psychocoderHPC psychocoderHPC added this to the 0.8.0 / Next stable milestone Feb 8, 2024
@psychocoderHPC psychocoderHPC marked this pull request as draft February 8, 2024 09:55
pordyna
pordyna approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@pordyna pordyna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the crashing setup. Did run 200 steps 672 times without a crash. The setup would previously crash within the first few reruns.

Still, this PR does not solve the issue with the very slow linear search and the resulting O(2) scaling.

@psychocoderHPC psychocoderHPC mentioned this pull request Feb 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pordyna pordyna pordyna approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug a bug in the project's code component: core in PIConGPU (core application)
Projects
None yet
Milestone
0.8.0 / Next stable
Development

Successfully merging this pull request may close these issues.
2 participants
@psychocoderHPC @pordyna