reviewer suggestions

ComputationalRadiationPhysics · Jul 31, 2024 · 05cf228 · 05cf228
1 parent 1d1f54b
commit 05cf228
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 11 deletions.
diff --git a/lib/python/picongpu/picmi/interaction/ionization/__init__.py b/lib/python/picongpu/picmi/interaction/ionization/__init__.py
@@ -1,6 +1,7 @@
 from .ionizationmodel import IonizationModel
 from .groundstateionizationmodel import GroundStateIonizationModel
 from . import fieldionization
+from . import electroniccollisionalequilibrium
 
 __all__ = [
  "IonizationModel",

diff --git a/lib/python/picongpu/picmi/predefinedparticletypeproperties.py b/lib/python/picongpu/picmi/predefinedparticletypeproperties.py
@@ -119,8 +119,4 @@
 }
 
 non_element_particle_type_properties = {}
-non_element_particle_type_properties.update(_quarks)
-non_element_particle_type_properties.update(_leptons)
-non_element_particle_type_properties.update(_neutrinos)
-non_element_particle_type_properties.update(_nucleons)
-non_element_particle_type_properties.update(_gauge_bosons)
+non_element_particle_type_properties.update(**_quarks, **_leptons, **_neutrinos, **_nucleons, **_gauge_bosons)
diff --git a/lib/python/picongpu/picmi/simulation.py b/lib/python/picongpu/picmi/simulation.py
@@ -368,10 +368,7 @@ def write_input_file(
 
  def picongpu_add_custom_user_input(self, custom_user_input: pypicongpu.customuserinput.InterfaceCustomUserInput):
  """add custom user input to previously stored input"""
- if self.picongpu_custom_user_input is None:
- self.picongpu_custom_user_input = [custom_user_input]
- else:
- self.picongpu_custom_user_input.append(custom_user_input)
+ self.picongpu_custom_user_input = (self.picongpu_custom_user_input + []) + [custom_user_input]
 
  def add_interaction(self, interaction) -> None:
  pypicongpu.util.unsupported(

diff --git a/lib/python/picongpu/picmi/species.py b/lib/python/picongpu/picmi/species.py
@@ -8,7 +8,7 @@
 from .. import pypicongpu
 from ..pypicongpu.species.util.element import Element
 from .interaction import InteractionInterface
-from .predefinedparticletypeproperties import non_element_particle_type_properties, _PropertyTuple
+from .predefinedparticletypeproperties import non_element_particle_type_properties
 
 import picmistandard
 
@@ -33,7 +33,7 @@ class Species(picmistandard.PICMI_Species):
  @attention ONLY set non-element particles here, all other are handled by element
  """
 
- __non_element_particle_types: dict[str, _PropertyTuple] = __non_element_particle_type_properties.keys()
+ __non_element_particle_types: list[str] = __non_element_particle_type_properties.keys()
  """list of particle types"""
 
  picongpu_element = pypicongpu.util.build_typesafe_property(typing.Optional[Element])