solana-ibc: avoid String allocations and multiple map lookups #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firstly, use BTreeMap::entry to avoid doing lookups in maps multiple times. With entry method we only need to traverse the map once. Secondly, use `foo.as_str()` rather than `&foo.to_string()` for client and connection ids so we avoid String allocations.
blasrodri
approved these changes
Oct 19, 2023
|
@dhruvja can check it out anyways to learn |
Yes yes I'm looking at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, use BTreeMap::entry to avoid doing lookups in maps multiple
times. With entry method we only need to traverse the map once.
Secondly, use
foo.as_str()rather than&foo.to_string()for clientand connection ids so we avoid String allocations.