added solana-ibc impl folder #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mina86
approved these changes
Oct 9, 2023
mina86
reviewed
Oct 9, 2023
mina86
reviewed
Oct 10, 2023
.gitignore
Outdated
Comment on lines
6
to
12
|
|
||
| .anchor | ||
| .DS_Store | ||
| target | ||
| **/*.rs.bk | ||
| node_modules | ||
| test-ledger |
There was a problem hiding this comment.
Suggested change
| .anchor | |
| .DS_Store | |
| target | |
| **/*.rs.bk | |
| node_modules | |
| test-ledger | |
| .anchor | |
| .DS_Store | |
| *.rs.bk | |
| node_modules | |
| test-ledger |
**/ doesn’t do anything useful since patterns in .gitignore aren’t anchored at root (unless prefixed with /). And I think we don’t need separate target since with workspace we will only have one target directory at repository’s root.
I’m not sure about node_modules but if you’re adding it as is, could you also remove existing /node_modules/? Sorting the lines wouln’t hurt either.
There was a problem hiding this comment.
sure sure, makes sense.
There was a problem hiding this comment.
once we configure the root to be the workspace for anchor, we wouldnt be needing the target folder. But i have added target such that it ignores any target it comes across.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.