Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Relayer for Solana #439

Draft
wants to merge 260 commits into
base: master
Choose a base branch
from
Draft

WIP Relayer for Solana #439

wants to merge 260 commits into from

Conversation

dhruvja
Copy link
Collaborator

@dhruvja dhruvja commented Oct 24, 2023

No description provided.

@dhruvja dhruvja changed the title relayer for Solana WIP Relayer for Solana Oct 24, 2023
Copy link
Contributor

@blasrodri blasrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Ask a review from Vlad as well

hyperspace/solana/src/accounts.rs Outdated Show resolved Hide resolved
hyperspace/solana/src/instructions.rs Outdated Show resolved Hide resolved
hyperspace/solana/src/instructions.rs Outdated Show resolved Hide resolved
hyperspace/solana/src/lib.rs Outdated Show resolved Hide resolved
.send_with_spinner_and_config(RpcSendTransactionConfig {
skip_preflight: true,
..RpcSendTransactionConfig::default()
}).unwrap();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better error handling?

hyperspace/solana/src/lib.rs Outdated Show resolved Hide resolved
@blasrodri
Copy link
Contributor

Why are you planning to store data in the relayer? Ideally querying the node should suffice

@dhruvja
Copy link
Collaborator Author

dhruvja commented Oct 26, 2023

Why are you planning to store data in the relayer? Ideally querying the node should suffice

I am not storing any data in the relayer. I am fetching the data from the accounts which are received from the rpc.

@dhruvja
Copy link
Collaborator Author

dhruvja commented Nov 23, 2023

Since i am having issues with different IBC versions, I will try to fork it and upgrade the IBC for solana and cosmos relayer. Lets see how it goes.
Forked Repo

@mina86
Copy link
Contributor

mina86 commented Nov 23, 2023

Upgrading is quite a big task though. What’s the main issue? It should be just a handful of types that we need from new ibc.

@dhruvja
Copy link
Collaborator Author

dhruvja commented Nov 23, 2023

I mean we just have to upgrade the ibc_primitives and the relayer for cosmos and solana.
I am already done with ibc_primitives and solana.

What’s the main issue?

Using the old ibc would need us to convert each type from our storage to the old ibc type. It can get messy.

@dhruvja
Copy link
Collaborator Author

dhruvja commented Dec 5, 2023

Well looks like @mina86 was right and upgrading seems to be a big task. So i will prolly use the old version of ibc and the new one to fetch the data from the smart contract. Would also write some conversions to convert some types from new ibc to old one.

@mina86
Copy link
Contributor

mina86 commented Dec 5, 2023

Note that with 0.48 ibc-rs got split into multiple smaller crates, so you’re probably gonna be interested only in the crates which define types.

@dhruvja
Copy link
Collaborator Author

dhruvja commented Dec 5, 2023

Note that with 0.48 ibc-rs got split into multiple smaller crates, so you’re probably gonna be interested only in the crates which define types.

gotcha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants