Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated datastream xml files for the test content image #163

Merged

Conversation

Vincent056
Copy link

There was a regression in the test content image quay.io/compliance-operator/test-broken-content:kublet_default on OCP 4.12 cluster, which caused the e2e test to fail. Since we have fix the test image, here we updated the datastream xml files for the test content image.

@openshift-ci openshift-ci bot requested review from jhrozek and rhmdnd October 18, 2022 20:15
@Vincent056
Copy link
Author

/retest

@rhmdnd
Copy link

rhmdnd commented Oct 19, 2022

This should fix #164 right?

CHANGELOG.md Outdated
@@ -24,7 +24,10 @@ Versioning](https://semver.org/spec/v2.0.0.html).
- Added a utility script to make it easier for maintainers to propose releases,
regardless of the git remote configuration. See the previously closed
[issue](https://github.com/ComplianceAsCode/compliance-operator/issues/8) for
more details.

- There was a regression in `quay.io/compliance-operator/test-broken-content:kublet_default`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be kubelet_default?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's correct, let me fix that


- There was a regression in `quay.io/compliance-operator/test-broken-content:kublet_default`
on OCP 4.12 cluster, which caused the e2e test to fail. Since we have fix the test image,
here we updated datastream xml files for the test content image.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to reference #164 here for people interested in the issue.

JAORMX
JAORMX previously requested changes Oct 20, 2022
Copy link
Collaborator

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivy seems unhappy with a dependency. You need to run:

go get -u golang.org/x/[email protected]
go mod tidy && go mod verify && go mod vendor

To address this.

@jhrozek
Copy link

jhrozek commented Oct 20, 2022

Trivy seems unhappy with a dependency. You need to run:

go get -u golang.org/x/[email protected]
go mod tidy && go mod verify && go mod vendor

To address this.

Thanks, I opened PR #166 to address this. Would you mind acking this so that @Vincent056 can rebase his PR and we can get the release out of the door?

@rhmdnd
Copy link

rhmdnd commented Oct 20, 2022

Thanks, I opened PR #166 to address this. Would you mind acking this so that @Vincent056 can rebase his PR and we can get the release out of the door?

I approved #166. Should be good to rebase this soon.

 There was a regression in test content image on OCP 4.12 cluster, which caused the e2e test to fail. Since we have fix the test image, here we updated datastream xml files for the test content image.
@Vincent056
Copy link
Author

Thanks, I opened PR #166 to address this. Would you mind acking this so that @Vincent056 can rebase his PR and we can get the release out of the door?

I approved #166. Should be good to rebase this soon.

Thanks for updating this, just rebased the PR here

Copy link

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Vincent056 Vincent056 dismissed JAORMX’s stale review October 20, 2022 18:27

Rebased the branch

@Vincent056
Copy link
Author

/px-approved
/qe-approved
/docs-approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants