-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated datastream xml files for the test content image #163
updated datastream xml files for the test content image #163
Conversation
/retest |
This should fix #164 right? |
CHANGELOG.md
Outdated
@@ -24,7 +24,10 @@ Versioning](https://semver.org/spec/v2.0.0.html). | |||
- Added a utility script to make it easier for maintainers to propose releases, | |||
regardless of the git remote configuration. See the previously closed | |||
[issue](https://github.com/ComplianceAsCode/compliance-operator/issues/8) for | |||
more details. | |||
|
|||
- There was a regression in `quay.io/compliance-operator/test-broken-content:kublet_default` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be kubelet_default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's correct, let me fix that
|
||
- There was a regression in `quay.io/compliance-operator/test-broken-content:kublet_default` | ||
on OCP 4.12 cluster, which caused the e2e test to fail. Since we have fix the test image, | ||
here we updated datastream xml files for the test content image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to reference #164 here for people interested in the issue.
eda6019
to
05f4f58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trivy seems unhappy with a dependency. You need to run:
go get -u golang.org/x/[email protected]
go mod tidy && go mod verify && go mod vendor
To address this.
Thanks, I opened PR #166 to address this. Would you mind acking this so that @Vincent056 can rebase his PR and we can get the release out of the door? |
I approved #166. Should be good to rebase this soon. |
There was a regression in test content image on OCP 4.12 cluster, which caused the e2e test to fail. Since we have fix the test image, here we updated datastream xml files for the test content image.
05f4f58
to
c8afef6
Compare
Thanks for updating this, just rebased the PR here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd, Vincent056 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/px-approved |
There was a regression in the test content image
quay.io/compliance-operator/test-broken-content:kublet_default
on OCP 4.12 cluster, which caused the e2e test to fail. Since we have fix the test image, here we updated the datastream xml files for the test content image.