-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for partial properties for [ObservableProperty] #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
added
feature 💡
A new feature being implemented
mvvm-toolkit 🧰
Issues/PRs for the MVVM Toolkit
analyzer 👓
A new analyzer being implemented or updated
labels
Oct 25, 2024
...eGenerators/Diagnostics/Analyzers/InvalidPropertyLevelObservablePropertyAttributeAnalyzer.cs
Outdated
Show resolved
Hide resolved
@@ -20,38 +20,54 @@ namespace CommunityToolkit.Mvvm.ComponentModel; | |||
/// partial class MyViewModel : ObservableObject | |||
/// { | |||
/// [ObservableProperty] | |||
/// private string name; | |||
/// public partial string name { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question: should "name" here also have a capital, since it's now a property? and the generated code below also seems to have a capital?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
analyzer 👓
A new analyzer being implemented or updated
feature 💡
A new feature being implemented
mvvm-toolkit 🧰
Issues/PRs for the MVVM Toolkit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #555
This PR updates the
[ObservableProperty]
generator to support partial properties as well.It includes the following changes:
PR Checklist