Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add strawberry to CDTB #103

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Neinndall
Copy link

I added CDTB in the same way as the other modes, strawberry (swarm mode) to get the augments, I'm just starting with python, but it seems to work!
On the other hand, I added strawberry to export as well, just in case it's needed.

obtain augments from the new swarm mode
add strawberry to export like the others modes if necessary
@benoitryder
Copy link
Member

I know almost nothing about this new game mode, so I won't be able to make relevant comments on the data being generated.
Here are some general remarks (not going into details about the code for now).

  • Do we know if Riot plans to make further editions of this mode? If it's only a temporary game mode, it's probably not worth exporting the files. It's nice to have a script as you did but it does not need to be in CDTB. If it's planned to be a major or recurrent mode, why not.
  • I think we should use the public name (Swarm) rather than the codename (Strawberry).
  • We must not hide errors with try/except. If something is wrong, we have to handle it correctly. This is important to avoid hiding errors in case format changes (which is very likely to happen if the game mode comes back).
  • Looking at the wiki, users will probably expect to have data on game elements other than augments (e.g. boons, items, ...). We don't have to provide everything in a first version but we should provide at least data for all the main elements.

@Neinndall
Copy link
Author

Neinndall commented Aug 5, 2024

had been thinking about it, but after the latest information from Riot, they have a team already dedicated to new game modes, I'm almost sure that this mode will not be abandoned, it will be something similar to the Arena mode, that's what I think.

On the other hand, I wanted to make a 1st version getting the augments something similar to the arena mode, although I've been looking at the .bin file carefully and we could add more info!

I could continue reviewing the code and trying to add improvements and try to add more content, obviously we can leave the "pull request" there in case things change, as you see!

Thanks for the answer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants