New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cpp warnings pass #567

Open

gcask wants to merge 3 commits into Community-A-4E:develop from gcask:cpp-warnings-pass

gcask commented Sep 26, 2022

Addressing a few C++ warnings.

90e815b is one that can lead to bugs and/or crashes (depending how lucky you get).
63b26ba is sanity (I assume all cases should already be covered).
df09dda is maintenance (seems like an oversight).

I can split them up into multiple PRs if it's more convenient!

gcask added 3 commits

September 26, 2022 11:14


          Switched to c++17

df09dda

fixing "constexpr is a C++17 extension warning"


          Not all control paths return a value

63b26ba


          returning address of local variable or temporary

90e815b

Author

gcask commented Sep 26, 2022

I deliberately did not include any binaries since apparently not all project are in the repo(?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet