Add system prop to store compound extensions types #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ligangty
force-pushed
the
master
branch
2 times, most recently
from
27ecb71
to
bbfbda5
Compare
sswguo
reviewed
Sep 2, 2024
| { | ||
| for ( final String type : typesFromSys.split( "," ) ) | ||
| { | ||
| COMPOUND_EXTENSIONS_TYPES.add( type.trim() ); |
There was a problem hiding this comment.
COMPOUND_EXTENSIONS_TYPES is a final variable, I guess it does not work here to add others. But from unit test, seems it does. ; -)
There was a problem hiding this comment.
I see. Ignore the comment here. LGTM.
There was a problem hiding this comment.
I guess it works technically; but looks a bit weird for a final 'set' to change, though. maybe rename to non final one.
There was a problem hiding this comment.
Sounds good as static final should be an immutable var. Let's change.
Because of maven classifier does not forbid dots, which makes it hard to decide the exact file types, so here add a temporary workaround to let user defines the exact file types for compound extensions to ditinguish the compound extensions types from classifier with dots.
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of maven classifier does not forbid dots, which makes it hard
to decide the exact file types, so here add a temporary workaround to
let user defines the exact file types for compound extensions to
ditinguish the compound extensions types from classifier with dots.