Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for hanging when run in an off-line environment #183

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Fix for hanging when run in an off-line environment #183

wants to merge 11 commits into from

Commits on Sep 14, 2024

  1. Add a timeout to requests on check_for_updates, default 10 but can be… 

    … set optionally. added PEP 585 type hints to functions in module.
    @jason-weirather
    jason-weirather committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    7f12c0c View commit details
    Browse the repository at this point in the history

  2. Fix: correct documentation issue in function check_for_updates

    @jason-weirather
    jason-weirather committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    47d31f0 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. instead of fail gracefully, pass a warning through logging. by loggin… 

    …g default settings this warning should be displayed
    @jason-weirather
    jason-weirather committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    6261b29 View commit details
    Browse the repository at this point in the history

  2. try to add a timeout with warning onto the tracking call to support t… 

    …he fully offline mode since its getting hit dispite disabiling tracking
    @jason-weirather
    jason-weirather committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    22c07d2 View commit details
    Browse the repository at this point in the history

  3. add success into the debug logs for tracking

    @jason-weirather
    jason-weirather committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    a10057b View commit details
    Browse the repository at this point in the history

  4. switch to a threading timeout

    @jason-weirather
    jason-weirather committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    1baf6e6 View commit details
    Browse the repository at this point in the history

  5. fix the call name being incorrect that we are sending to threading

    @jason-weirather
    jason-weirather committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    f88a773 View commit details
    Browse the repository at this point in the history

  6. put tracking back to the way it was but fix its bug where it sets con… 

    …stants to a string which is assumed to a bool causing it to always evaluate to true
    @jason-weirather
    jason-weirather committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    9866329 View commit details
    Browse the repository at this point in the history

  7. specify we are pulling a boolean

    @jason-weirather
    jason-weirather committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    1a3778d View commit details
    Browse the repository at this point in the history

  8. add consistency to tracking varible use

    @jason-weirather
    jason-weirather committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    c847769 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. notice that code expects None could be a valid setting for the config… 

    …uration, so don't cast to a bool when checking that
    @jason-weirather
    jason-weirather committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    3b2fb3d View commit details
    Browse the repository at this point in the history