Merge pull request #21 from tjjwilson/master

Adding Offset to SignalPointInsertion
Comcast · Jun 13, 2022 · f054141 · f054141
2 parents 64c2dca + 4d6a218
commit f054141
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/types/scte224v20180501/sctestructures.go b/types/scte224v20180501/sctestructures.go
@@ -223,6 +223,7 @@ type SignalPointDeletionAction struct {
 type SignalPointInsertionAction struct {
 	SignalPoints   []*SignalPoint `xml:"urn:scte:224:action SignalPoint,omitempty" json:"signalPoint,omitempty"`
 	ActionProperty []Any          `xml:",any" json:"actionProperty,omitempty"`
+	Offset         Duration       `xml:"offset,attr,omitempty" json:"offset,omitempty"`
 }
 
 type SignalPoint struct {

diff --git a/types/scte224v20200407/avp.go b/types/scte224v20200407/avp.go
@@ -95,6 +95,7 @@ func (vp *ViewingPolicy) Get2018() scte224_2018.ViewingPolicy {
 
 		destination.SignalPointInsertion = &scte224_2018.SignalPointInsertionAction{
 			SignalPoints: signalPoints2018,
+			Offset:       scte224_2018.Duration(vp.SignalPointInsertion.Offset),
 		}
 
 		vpActionProps2018 := make([]scte224_2018.Any, 0, len(vp.SignalPointInsertion.ActionProperty))
@@ -188,6 +189,7 @@ type SignalPointDeletionAction struct {
 type SignalPointInsertionAction struct {
 	SignalPoints   []*SignalPoint `xml:"urn:scte:224:action SignalPoint,omitempty" json:"signalPoint,omitempty"`
 	ActionProperty []Any          `xml:",any" json:"actionProperty,omitempty"`
+	Offset         Duration       `xml:"offset,attr,omitempty" json:"offset,omitempty"`
 }
 
 type SignalPoint struct {

diff --git a/types/scte224v20200407/constants_test.go b/types/scte224v20200407/constants_test.go
@@ -25,7 +25,7 @@ const vp2020Raw string = `<ViewingPolicy xmlns="http://www.scte.org/schemas/224"
 
 const vpSignalPointInsertion_w_SpliceInfoSection string = `<ViewingPolicy xmlns="http://www.scte.org/schemas/224" id="test.com/viewingpolicy/test/testVP1" description="Test VP with SignalPointInsertion containing a SpliceInfoSection" lastUpdated="2022-04-27T22:09:55Z">
   <Audience xmlns="http://www.scte.org/schemas/224" xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="test.com/audience/test/testaudience"></Audience>
-  <SignalPointInsertion xmlns="urn:scte:224:action">
+  <SignalPointInsertion xmlns="urn:scte:224:action" offset="PT1M">
     <SpliceInfoSection xmlns="http://www.scte.org/schemas/35" offset="PT1M">
       <TimeSignal xmlns="http://www.scte.org/schemas/35">
         <SpliceTime xmlns="http://www.scte.org/schemas/35" ptsTime="0"></SpliceTime>