-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correcting typo in variable name #81
base: master
Are you sure you want to change the base?
Conversation
I noticed com.comcast.money.java.servlet.TraceFilter made repeated reference to an incTrcaceId. The pedant and copy editor trapped inside this programmer's body could not let this alone. This change is solely to correct this typo and restore some sense of inner peace to myself and any other similarly afflicted folks who may happen upon this source code.
|
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
======================================
Coverage 90.9% 90.9%
======================================
Files 30 30
Lines 594 594
Branches 57 57
======================================
Hits 540 540
Misses 54 54
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know who you are Peter Client, but you need to sign the CLA on the PR before I can merge this.
Thanks for the submission!
When I check the cla assistant it tells me the cla is already signed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot merge tho until you sign the CLA
I've tried signing it multiple times. Every time I try I'm told it is
already signed. This has been the case since day one. I've no idea how to
proceed.
…On Sat, 10 Mar 2018, 08:35 Paul Cleary, ***@***.***> wrote:
***@***.**** approved this pull request.
Cannot merge tho until you sign the CLA
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#81 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAYAVyKFzjldIxSXq518hdWviXdXQhsQks5tc9a2gaJpZM4PGBoV>
.
|
I'm a bit late to this but I had a similar problem because there was code in the repository written on my work github account so I had to sign in as that user then sign the CLA. Basically every user who has code in the PR has to sign. Not sure if that would be the issue here. |
Yes, @petercline The commit says "omicron committed on Aug 29, 2017" I wonder if that is where it is getting confused. The commit author is different than "petercline" |
I noticed com.comcast.money.java.servlet.TraceFilter made repeated
reference to an incTrcaceId. The pedant and copy editor trapped inside
this programmer's body could not let this alone.
This change is solely to correct this typo and restore some sense of
inner peace to myself and any other similarly afflicted folks who may
happen upon this source code.