Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting typo in variable name #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

petercline
Copy link
Member

I noticed com.comcast.money.java.servlet.TraceFilter made repeated
reference to an incTrcaceId. The pedant and copy editor trapped inside
this programmer's body could not let this alone.

This change is solely to correct this typo and restore some sense of
inner peace to myself and any other similarly afflicted folks who may
happen upon this source code.

I noticed com.comcast.money.java.servlet.TraceFilter made repeated
reference to an incTrcaceId.  The pedant and copy editor trapped inside
this programmer's body could not let this alone.

This change is solely to correct this typo and restore some sense of
inner peace to myself and any other similarly afflicted folks who may
happen upon this source code.
@CLAassistant
Copy link

CLAassistant commented Aug 29, 2017

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-io
Copy link

Codecov Report

Merging #81 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #81   +/-   ##
======================================
  Coverage    90.9%   90.9%           
======================================
  Files          30      30           
  Lines         594     594           
  Branches       57      57           
======================================
  Hits          540     540           
  Misses         54      54
Impacted Files Coverage Δ
...a/com/comcast/money/java/servlet/TraceFilter.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1760cc7...0ca497b. Read the comment docs.

Copy link
Member

@pauljamescleary pauljamescleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know who you are Peter Client, but you need to sign the CLA on the PR before I can merge this.

Thanks for the submission!

@petercline
Copy link
Member Author

When I check the cla assistant it tells me the cla is already signed.

Copy link
Member

@pauljamescleary pauljamescleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot merge tho until you sign the CLA

@petercline
Copy link
Member Author

petercline commented Mar 14, 2018 via email

@petercline
Copy link
Member Author

Here's what I see when I try to sign again
screen shot 2018-03-13 at 10 58 44 pm

@ptravers
Copy link
Collaborator

ptravers commented Apr 2, 2018

I'm a bit late to this but I had a similar problem because there was code in the repository written on my work github account so I had to sign in as that user then sign the CLA.

Basically every user who has code in the PR has to sign. Not sure if that would be the issue here.

@pauljamescleary
Copy link
Member

Yes, @petercline The commit says "omicron committed on Aug 29, 2017"

I wonder if that is where it is getting confused. The commit author is different than "petercline"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants