Introduce EXT-X-SKIP support (Targeting version 2.x) #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: mambaTests/PlaylistStructureAndEditingTests.swift
Conflicts: mambaTests/PantosTagTests.swift
Conflicts: mambaSharedFramework/HLS Models/Playlist Structure/HLSPlaylistStructure.swift
theRealRobG
added
enhancement
mamba2.0
Conflicts: mambaSharedFramework/Playlist Models/Playlist Structure/PlaylistStructureCore.swift
rmigneco
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cherry-picks the changes from #130 into a branch based out of
developto create a version compatible with version 2 of the library.Change Notes
EXT_X_SKIP) to thePantosTagenum and made the necessary updates for theHLSTagDescriptorconformance.PantosValueto account for attributes related to EXT-X-SKIP (.skippedSegmentsand.recentlyRemovedDateranges).generateMediaGroupsforHLSPlaylistStructureto account for anySKIPPED-SEGMENTSwhen calculating media sequence values for segment tag groups.Pre-submission Checklist